From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1944) id BE06F3852C61; Wed, 23 Nov 2022 14:49:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BE06F3852C61 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669214966; bh=fRFu1Rakw3vl+M1l9Ht1EHoFznTmDQuxnff8TxyyiTY=; h=From:To:Subject:Date:From; b=K9TcmBSFmqLpmgpkfRgnoMJaDOgDOJhNT3N/n18dfNIrQQtxRN6KpE0N5+9U9GVpI ZXPGrNngaHzM735v36KLudGPWrK9VIhZjt+xz5ZGG60eTfYBPDV9OOJ3ZO4iTnUpzr XaHqYkYH6kJsmHV2W8GZYHfllgWHfOuQ+x2ZnFPg= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Szabolcs Nagy To: glibc-cvs@sourceware.org Subject: [glibc/arm/morello/main] cheri: fix posix timers X-Act-Checkin: glibc X-Git-Author: Szabolcs Nagy X-Git-Refname: refs/heads/arm/morello/main X-Git-Oldrev: 3e833b93fd62b42d02b65c51d081b10afc23e389 X-Git-Newrev: abb1d6bb4114b95391d9e50de5bda4302bca950a Message-Id: <20221123144926.BE06F3852C61@sourceware.org> Date: Wed, 23 Nov 2022 14:49:26 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=abb1d6bb4114b95391d9e50de5bda4302bca950a commit abb1d6bb4114b95391d9e50de5bda4302bca950a Author: Szabolcs Nagy Date: Tue Apr 19 15:18:56 2022 +0100 cheri: fix posix timers We need to distinguish timerids that are small integers returned by the kernel and timerids that are pointers to struct timer. The existing pointer tagging does not work for CHERI because of the pointer shift. Simply use the top bit without shift to tag pointers. This still relies on the top byte ignore of aarch64 (the top byte does not affect the capability representation) and that pointers are not tagged for other reasons (like HWASAN). Note: this is morello specific and does not work for generic cheri. Diff: --- sysdeps/unix/sysv/linux/kernel-posix-timers.h | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/sysdeps/unix/sysv/linux/kernel-posix-timers.h b/sysdeps/unix/sysv/linux/kernel-posix-timers.h index 82ce92f2ae..371e328258 100644 --- a/sysdeps/unix/sysv/linux/kernel-posix-timers.h +++ b/sysdeps/unix/sysv/linux/kernel-posix-timers.h @@ -79,6 +79,25 @@ kernel_timer_to_timerid (kernel_timer_t ktimerid) return (timer_t) ((intptr_t) ktimerid); } +#ifdef __CHERI_PURE_CAPABILITY__ +static inline timer_t +timer_to_timerid (struct timer *ptr) +{ + return (timer_t) ((uintptr_t) ptr | ~(-1UL/2)); +} + +static inline bool +timer_is_sigev_thread (timer_t timerid) +{ + return ((uintptr_t) timerid & ~(-1UL/2)) != 0; +} + +static inline struct timer * +timerid_to_timer (timer_t timerid) +{ + return (struct timer *)((uintptr_t) timerid & (-1UL/2)); +} +#else static inline timer_t timer_to_timerid (struct timer *ptr) { @@ -96,6 +115,7 @@ timerid_to_timer (timer_t timerid) { return (struct timer *)((uintptr_t) timerid << 1); } +#endif static inline kernel_timer_t timerid_to_kernel_timer (timer_t timerid)