public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc] Linux: consolidate dup2 implementation Date: Wed, 7 Dec 2022 19:14:54 +0000 (GMT) [thread overview] Message-ID: <20221207191454.4D86D390CEAE@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=33ef940302eba1ecf9e98376557af75d7d9c0ed1 commit 33ef940302eba1ecf9e98376557af75d7d9c0ed1 Author: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org> Date: Wed Oct 19 19:14:08 2022 -0300 Linux: consolidate dup2 implementation Use dup2 syscall if defined, otherwise use dup3. Checked on x86_64-linux-gnu. Reviewed-by: Carlos O'Donell <carlos@redhat.com> Tested-by: Carlos O'Donell <carlos@redhat.com> Diff: --- sysdeps/unix/sysv/linux/{generic => }/dup2.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/sysdeps/unix/sysv/linux/generic/dup2.c b/sysdeps/unix/sysv/linux/dup2.c similarity index 83% rename from sysdeps/unix/sysv/linux/generic/dup2.c rename to sysdeps/unix/sysv/linux/dup2.c index 0dc45e9b17..1182780e15 100644 --- a/sysdeps/unix/sysv/linux/generic/dup2.c +++ b/sysdeps/unix/sysv/linux/dup2.c @@ -1,4 +1,5 @@ -/* Copyright (C) 2011-2022 Free Software Foundation, Inc. +/* Duplicate a file descriptor. Linux version. + Copyright (C) 2011-2022 Free Software Foundation, Inc. This file is part of the GNU C Library. The GNU C Library is free software; you can redistribute it and/or @@ -24,12 +25,16 @@ int __dup2 (int fd, int fd2) { +#ifdef __NR_dup2 + return INLINE_SYSCALL_CALL (dup2, fd, fd2); +#else /* For the degenerate case, check if the fd is valid (by trying to get the file status flags) and return it, or else return EBADF. */ if (fd == fd2) return __libc_fcntl (fd, F_GETFL, 0) < 0 ? -1 : fd; - return INLINE_SYSCALL (dup3, 3, fd, fd2, 0); + return INLINE_SYSCALL_CALL (dup3, fd, fd2, 0); +#endif } libc_hidden_def (__dup2) weak_alias (__dup2, dup2)
reply other threads:[~2022-12-07 19:14 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221207191454.4D86D390CEAE@sourceware.org \ --to=azanella@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).