public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] elf: Fix tst-relro-symbols.py argument passing
@ 2022-12-15 19:59 Adhemerval Zanella
  0 siblings, 0 replies; only message in thread
From: Adhemerval Zanella @ 2022-12-15 19:59 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=71e408e45dcacf429a94b2807f75aaadd8d37cb9

commit 71e408e45dcacf429a94b2807f75aaadd8d37cb9
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Wed Dec 14 18:18:34 2022 -0300

    elf: Fix tst-relro-symbols.py argument passing
    
    Current scheme only consideres the first argument for both --required
    and --optional, where the idea is to append a new item.
    
    Checked on x86_64-linux-gnu.
    
    Reviewed-by: Florian Weimer <fweimer@redhat.com>

Diff:
---
 elf/tst-relro-symbols.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/elf/tst-relro-symbols.py b/elf/tst-relro-symbols.py
index 368ea3349f..ea61024b5e 100644
--- a/elf/tst-relro-symbols.py
+++ b/elf/tst-relro-symbols.py
@@ -56,10 +56,10 @@ def get_parser():
     """Return an argument parser for this script."""
     parser = argparse.ArgumentParser(description=__doc__)
     parser.add_argument('object', help='path to object file to check')
-    parser.add_argument('--required', metavar='NAME', default=(),
-                        help='required symbol names', nargs='*')
-    parser.add_argument('--optional', metavar='NAME', default=(),
-                        help='required symbol names', nargs='*')
+    parser.add_argument('--required', metavar='NAME', action='append',
+                        default=[], help='required symbol names')
+    parser.add_argument('--optional', metavar='NAME', action='append',
+                        default=[], help='required symbol names')
     return parser
 
 def main(argv):

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-12-15 19:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-15 19:59 [glibc] elf: Fix tst-relro-symbols.py argument passing Adhemerval Zanella

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).