From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id 7F2E23858D39; Thu, 29 Dec 2022 12:53:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7F2E23858D39 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1672318398; bh=ZYh8tiujyOZSp3d96rBJXveYb3XSLBbBCXsHMRp5eTg=; h=From:To:Subject:Date:From; b=aNG1Nikcrv2ol6/LaT9WnmRwYg6IGNCIhdXTzhfcycogiz0O+0yRQ3TU9v9usyRMY 9G63jJ9FlLSbb2C+1YjvgxuYGuRrU2J/z0UaKh5kdhHPq+F5PuSqRukOUUnck07DR6 8gYb3UVlZ6UBt42h3rvNsqKypI0QlFsySlWRWPAs= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/release/2.36/master] x86: Fix -Os build (BZ #29576) X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella Netto X-Git-Refname: refs/heads/release/2.36/master X-Git-Oldrev: 997d844a97b0478a3a7f9e7d7027c7431edbb51d X-Git-Newrev: 4f4d7a13edfd2fdc57c9d76e1fd6d017fb47550c Message-Id: <20221229125318.7F2E23858D39@sourceware.org> Date: Thu, 29 Dec 2022 12:53:18 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=4f4d7a13edfd2fdc57c9d76e1fd6d017fb47550c commit 4f4d7a13edfd2fdc57c9d76e1fd6d017fb47550c Author: Adhemerval Zanella Netto Date: Wed Sep 21 10:51:08 2022 -0300 x86: Fix -Os build (BZ #29576) The compiler might transform __stpcpy calls (which are routed to __builtin_stpcpy as an optimization) to strcpy and x86_64 strcpy multiarch implementation does not build any working symbol due ISA_SHOULD_BUILD not being evaluated for IS_IN(rtld). Checked on x86_64-linux-gnu. Reviewed-by: Carlos O'Donell Tested-by: Carlos O'Donell (cherry picked from commit 9dc4e29f630c6ef8299120b275e503321dc0c8c7) Diff: --- NEWS | 2 ++ sysdeps/x86_64/multiarch/rtld-strcpy.S | 18 ++++++++++++++++++ 2 files changed, 20 insertions(+) diff --git a/NEWS b/NEWS index c3df0c007d..fb2d73a6be 100644 --- a/NEWS +++ b/NEWS @@ -39,6 +39,8 @@ The following bugs are resolved with this release: [29528] elf: Call __libc_early_init for reused namespaces [29537] libc: [2.34 regression]: Alignment issue on m68k when using [29539] libc: LD_TRACE_LOADED_OBJECTS changed how vDSO library are + [29576] build: librtld.os: in function `_dl_start_profile': + (.text+0x9444): undefined reference to `strcpy' [29583] Use 64-bit interfaces in gconv_parseconfdir [29600] Do not completely clear reused namespace in dlmopen [29607] nscd repeatably crashes calling __strlen_avx2 when hosts cache is diff --git a/sysdeps/x86_64/multiarch/rtld-strcpy.S b/sysdeps/x86_64/multiarch/rtld-strcpy.S new file mode 100644 index 0000000000..19439c553d --- /dev/null +++ b/sysdeps/x86_64/multiarch/rtld-strcpy.S @@ -0,0 +1,18 @@ +/* Copyright (C) 2022 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include "../strcpy.S"