From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1792) id B3E193858408; Mon, 2 Jan 2023 10:36:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B3E193858408 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1672655796; bh=DwEDEYNOIeOq05PPXDUT/26Wls3MRXaOyxfCGuoewG8=; h=From:To:Subject:Date:From; b=EoeCvW+AeDGbo2tH7siBCRM5vCudfLnkb5SJwvyWLXpDXUtHKQ3Dhc4wOIfslhXxn +btisjryVGYIw6Otib0L3jhZFL++7IrY+us1mPINP4vgOzZJK+sAqUANyFf6MnkqxB PA3CP6RMC+/bRL5DQ9tkNUvVaY9EOfkEnFhc7+Ek= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Samuel Thibault To: glibc-cvs@sourceware.org Subject: [glibc] hurd: Make dl-sysdep __sbrk check __vm_allocate call X-Act-Checkin: glibc X-Git-Author: Samuel Thibault X-Git-Refname: refs/heads/master X-Git-Oldrev: cba62c231c0ba67b5cc6f3beb07571f316f9deeb X-Git-Newrev: b7a5fec8b04edb505f51c207ae50b6777c2c55b2 Message-Id: <20230102103636.B3E193858408@sourceware.org> Date: Mon, 2 Jan 2023 10:36:36 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b7a5fec8b04edb505f51c207ae50b6777c2c55b2 commit b7a5fec8b04edb505f51c207ae50b6777c2c55b2 Author: Samuel Thibault Date: Mon Jan 2 01:49:59 2023 +0100 hurd: Make dl-sysdep __sbrk check __vm_allocate call The caller won't be able to progress, but better crash than use random addr. Diff: --- sysdeps/mach/hurd/dl-sysdep.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sysdeps/mach/hurd/dl-sysdep.c b/sysdeps/mach/hurd/dl-sysdep.c index 2f022ee90c..84fe966efe 100644 --- a/sysdeps/mach/hurd/dl-sysdep.c +++ b/sysdeps/mach/hurd/dl-sysdep.c @@ -699,7 +699,8 @@ void *weak_function __sbrk (intptr_t increment) { vm_address_t addr; - __vm_allocate (__mach_task_self (), &addr, increment, 1); + if (__vm_allocate (__mach_task_self (), &addr, increment, 1)) + return NULL; return (void *) addr; }