public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/azanella/clang] stdlib: DIAG_IGNORE_NEEDS_COMMENT setenv.c
Date: Thu,  9 Feb 2023 19:45:36 +0000 (GMT)	[thread overview]
Message-ID: <20230209194536.823033858028@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=084a6ab96f67328c543f697d983977448f1ee912

commit 084a6ab96f67328c543f697d983977448f1ee912
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Tue Mar 8 17:37:11 2022 -0300

    stdlib: DIAG_IGNORE_NEEDS_COMMENT setenv.c
    
    Checked on x86_64-linux-gnu.

Diff:
---
 stdlib/setenv.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/stdlib/setenv.c b/stdlib/setenv.c
index ba5257d3bf..dda7a4a9c2 100644
--- a/stdlib/setenv.c
+++ b/stdlib/setenv.c
@@ -19,12 +19,14 @@
 # include <config.h>
 #endif
 
+#if _LIBC
+# include <libc-diag.h>
 /* Pacify GCC; see the commentary about VALLEN below.  This is needed
    at least through GCC 4.9.2.  Pacify GCC for the entire file, as
    there seems to be no way to pacify GCC selectively, only for the
-   place where it's needed.  Do not use DIAG_IGNORE_NEEDS_COMMENT
-   here, as it's not defined yet.  */
-#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
+   place where it's needed.  */
+DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wmaybe-uninitialized");
+#endif
 
 #include <errno.h>
 #if !_LIBC

             reply	other threads:[~2023-02-09 19:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-09 19:45 Adhemerval Zanella [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-08-30 12:33 Adhemerval Zanella
2022-10-28 17:37 Adhemerval Zanella
2022-10-04 12:55 Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230209194536.823033858028@sourceware.org \
    --to=azanella@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).