public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/azanella/clang] misc: Disable some atomic tests on clang
Date: Thu,  9 Feb 2023 19:51:52 +0000 (GMT)	[thread overview]
Message-ID: <20230209195152.282453858C5F@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=88221bd413d969c52ffafd4d31f46ff7357a0c47

commit 88221bd413d969c52ffafd4d31f46ff7357a0c47
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Fri Mar 25 11:22:44 2022 -0300

    misc: Disable some atomic tests on clang
    
    clang warns on some atomic macros, disable for now:
    
      tst-atomic.c:463:7: error: unsupported inline asm: input with type
      'int64_t' (aka 'long') matching output with type 'typeof (*&mem)' (aka
      'int')
        if (catomic_exchange_and_add (&mem, 11) != 2
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      ../sysdeps/x86/atomic-machine.h:213:3: note: expanded from macro
      'catomic_exchange_and_add'
        __arch_exchange_and_add_body (__arch_exchange_and_add_cprefix,
      __arch_c,    \
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      ../sysdeps/x86/atomic-machine.h:199:12: note: expanded from macro
      '__arch_exchange_and_add_body'
                               : "0" ((int64_t) cast_to_integer (__addval)),
      \
                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      tst-atomic.c:487:7: error: unsupported inline asm: input with type
      'int64_t' (aka 'long') matching output with type 'typeof (*(&mem))' (aka
      'int')
        if (catomic_increment_val (&mem) != 3)
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      ../include/atomic.h:313:38: note: expanded from macro
      'catomic_increment_val'
      # define catomic_increment_val(mem) (catomic_exchange_and_add ((mem), 1)
      + 1)
                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      ../sysdeps/x86/atomic-machine.h:213:3: note: expanded from macro
      'catomic_exchange_and_add'
        __arch_exchange_and_add_body (__arch_exchange_and_add_cprefix,
      __arch_c,    \
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      ../sysdeps/x86/atomic-machine.h:199:12: note: expanded from macro
      '__arch_exchange_and_add_body'
                               : "0" ((int64_t) cast_to_integer (__addval)),
      \
                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      tst-atomic.c:501:7: error: unsupported inline asm: input with type
      'int64_t' (aka 'long') matching output with type 'typeof (*(&mem))' (aka
      'int')
        if (catomic_decrement_val (&mem) != 15)
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      ../include/atomic.h:340:38: note: expanded from macro
      'catomic_decrement_val'
      # define catomic_decrement_val(mem) (catomic_exchange_and_add ((mem),
      -1) - 1)
                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      ../sysdeps/x86/atomic-machine.h:213:3: note: expanded from macro
      'catomic_exchange_and_add'
        __arch_exchange_and_add_body (__arch_exchange_and_add_cprefix,
      __arch_c,    \
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      ../sysdeps/x86/atomic-machine.h:199:12: note: expanded from macro
      '__arch_exchange_and_add_body'
                               : "0" ((int64_t) cast_to_integer (__addval)),
      \
                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Diff:
---
 misc/tst-atomic.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/misc/tst-atomic.c b/misc/tst-atomic.c
index 013ce9d0dd..d732265d80 100644
--- a/misc/tst-atomic.c
+++ b/misc/tst-atomic.c
@@ -459,6 +459,7 @@ do_test (void)
       ret = 1;
     }
 
+#ifndef __clang__
   mem = 2;
   if (catomic_exchange_and_add (&mem, 11) != 2
       || mem != 13)
@@ -466,6 +467,7 @@ do_test (void)
       puts ("catomic_exchange_and_add test failed");
       ret = 1;
     }
+#endif
 
   mem = -21;
   catomic_add (&mem, 22);
@@ -483,12 +485,14 @@ do_test (void)
       ret = 1;
     }
 
+#ifndef __clang__
   mem = 2;
   if (catomic_increment_val (&mem) != 3)
     {
       puts ("catomic_increment_val test failed");
       ret = 1;
     }
+#endif
 
   mem = 17;
   catomic_decrement (&mem);
@@ -498,11 +502,13 @@ do_test (void)
       ret = 1;
     }
 
+#ifndef __clang__
   if (catomic_decrement_val (&mem) != 15)
     {
       puts ("catomic_decrement_val test failed");
       ret = 1;
     }
+#endif
 
   /* Tests for C11-like atomics.  */
   mem = 11;

             reply	other threads:[~2023-02-09 19:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-09 19:51 Adhemerval Zanella [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-04-17 20:10 Adhemerval Zanella
2024-04-02 15:56 Adhemerval Zanella
2024-02-09 17:35 Adhemerval Zanella
2024-02-07 14:10 Adhemerval Zanella
2024-01-29 18:00 Adhemerval Zanella
2023-12-21 18:57 Adhemerval Zanella
2023-09-28 17:55 Adhemerval Zanella
2023-08-30 12:39 Adhemerval Zanella
2022-10-28 17:45 Adhemerval Zanella
2022-10-04 13:02 Adhemerval Zanella
2022-06-09 21:23 Adhemerval Zanella
2022-06-09 13:20 Adhemerval Zanella
2022-06-03 14:09 Adhemerval Zanella
2022-05-13 14:23 Adhemerval Zanella
2022-05-12 19:37 Adhemerval Zanella
2022-05-10 18:27 Adhemerval Zanella
2022-04-29 14:07 Adhemerval Zanella
2022-04-04 12:57 Adhemerval Zanella
2022-03-31 19:10 Adhemerval Zanella
2022-03-29 20:33 Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230209195152.282453858C5F@sourceware.org \
    --to=azanella@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).