public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/azanella/clang] conform: Replace _Static_assert with macro
Date: Thu, 9 Feb 2023 19:52:47 +0000 (GMT) [thread overview]
Message-ID: <20230209195247.F3A803857C43@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ca96e1f8ca33aa81a5b32a77600998036978636f
commit ca96e1f8ca33aa81a5b32a77600998036978636f
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date: Tue Mar 29 16:06:13 2022 -0300
conform: Replace _Static_assert with macro
clang does not allow non integral constant expression in
_Static_assert. Replace with a macro that uses name bit-field
where an invalid constant expression sets its size to 0, resulting
in a error.
Diff:
---
conform/conformtest.py | 21 ++++++++++++++++-----
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/conform/conformtest.py b/conform/conformtest.py
index fcaab48a6c..e89fb19134 100644
--- a/conform/conformtest.py
+++ b/conform/conformtest.py
@@ -157,9 +157,9 @@ class ConstantTest(object):
'%s'
'# define conformtest_%d_value (%s)\n'
'#endif\n'
- '_Static_assert (((%s < 0) == conformtest_%d_negative) '
+ 'STATIC_ASSERT (((%s < 0) == conformtest_%d_negative) '
'&& (%s == conformtest_%d_value), '
- '"value match inside and outside #if");\n'
+ 'value_match_inside_and_outside_if);\n'
% (self.symbol, self.num, sym_bits_def_neg, self.num,
sym_bits_or_neg, self.num, sym_bits_def_pos, self.num,
sym_bits_or_pos, self.symbol, self.num, self.symbol,
@@ -179,8 +179,8 @@ class ConstantTest(object):
'Type of symbol %s' % self.symbol,
text))
if self.op is not None:
- text = ('_Static_assert (%(symbol)s %(op)s %(value)s, '
- '"value constraint");\n'
+ text = ('STATIC_ASSERT (%(symbol)s %(op)s %(value)s, '
+ 'value_constraint);\n'
% vars(self))
self.subtests.append(CompileSubTest(
'Value of symbol %s' % self.symbol,
@@ -552,6 +552,16 @@ class HeaderTests(object):
self.skipped += 1
sys.stdout.flush()
+ def common_definitions(self):
+ """Add any required common definition for the compilation tests."""
+ text = ('#define __STR(pre,post) pre ## post\n'
+ '#define _STR(pre,post) __STR(pre, post)\n'
+ '#define STATIC_ASSERT(cond, msg) \\\n'
+ ' typedef struct {\\\n'
+ ' int _STR (static_assertion_failed_, msg) : !!(cond);\\\n'
+ ' } _STR (static_assertion_failed_, __COUNTER__)\n')
+ return text
+
def compile_test(self, name, text):
"""Run a compilation test; return True if it passes."""
self.total += 1
@@ -565,7 +575,8 @@ class HeaderTests(object):
c_file = os.path.join(self.temp_dir, 'test.c')
o_file = os.path.join(self.temp_dir, 'test.o')
with open(c_file, 'w') as c_file_out:
- c_file_out.write('#include <%s>\n%s' % (self.header, text))
+ c_file_out.write('#include <%s>\n%s\n%s' %
+ (self.header, self.common_definitions(), text))
cmd = ('%s %s -c %s -o %s' % (self.cc, self.cflags, c_file, o_file))
try:
subprocess.check_call(cmd, shell=True)
next reply other threads:[~2023-02-09 19:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 19:52 Adhemerval Zanella [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-03-25 20:24 Adhemerval Zanella
2024-04-17 20:11 Adhemerval Zanella
2024-04-02 15:57 Adhemerval Zanella
2024-02-09 17:36 Adhemerval Zanella
2024-02-07 14:11 Adhemerval Zanella
2024-01-29 18:01 Adhemerval Zanella
2023-12-21 18:58 Adhemerval Zanella
2023-09-28 17:56 Adhemerval Zanella
2023-08-30 12:40 Adhemerval Zanella
2022-10-28 17:45 Adhemerval Zanella
2022-10-04 13:03 Adhemerval Zanella
2022-06-09 21:24 Adhemerval Zanella
2022-06-09 13:21 Adhemerval Zanella
2022-06-03 14:10 Adhemerval Zanella
2022-05-13 14:24 Adhemerval Zanella
2022-05-12 19:38 Adhemerval Zanella
2022-05-10 18:28 Adhemerval Zanella
2022-04-29 14:08 Adhemerval Zanella
2022-04-04 12:58 Adhemerval Zanella
2022-03-31 19:11 Adhemerval Zanella
2022-03-29 20:35 Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230209195247.F3A803857C43@sourceware.org \
--to=azanella@sourceware.org \
--cc=glibc-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).