public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Samuel Thibault <sthibaul@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] mach: Use PAGE_SIZE
Date: Sun, 19 Feb 2023 23:46:59 +0000 (GMT)	[thread overview]
Message-ID: <20230219234659.F23F13858D37@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=be318c0f38b6b72a0716edce818b755411e75600

commit be318c0f38b6b72a0716edce818b755411e75600
Author: Sergey Bugaev <bugaevc@gmail.com>
Date:   Sat Feb 18 23:37:14 2023 +0300

    mach: Use PAGE_SIZE
    
    The PAGE_SIZE from the Mach headers statically defines the machine's
    page size. There's no need to query it dynamically; furthermore, the
    implementation of the vm_statistics () RPC unconditionally fills in
    
    pagesize = PAGE_SIZE;
    
    Not doing the extra RPC shaves off 2 RPCs from the start-up of every
    process!
    
    Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
    Message-Id: <20230218203717.373211-7-bugaevc@gmail.com>

Diff:
---
 mach/mach_init.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/mach/mach_init.c b/mach/mach_init.c
index a0d9f7f5e2..42b9cacf68 100644
--- a/mach/mach_init.c
+++ b/mach/mach_init.c
@@ -17,6 +17,7 @@
 
 #include <mach.h>
 #include <mach/mig_support.h>
+#include <mach/vm_param.h>
 #include <unistd.h>
 
 mach_port_t __mach_task_self_;
@@ -38,7 +39,10 @@ __mach_init (void)
   __mach_host_self_ = (__mach_host_self) ();
   __mig_init (0);
 
-#ifdef HAVE_HOST_PAGE_SIZE
+#ifdef PAGE_SIZE
+  __vm_page_size = PAGE_SIZE;
+  (void) err;
+#elif defined (HAVE_HOST_PAGE_SIZE)
   if (err = __host_page_size (__mach_host_self (), &__vm_page_size))
     _exit (err);
 #else

                 reply	other threads:[~2023-02-19 23:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230219234659.F23F13858D37@sourceware.org \
    --to=sthibaul@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).