From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id D6254385B51F; Mon, 20 Feb 2023 13:03:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D6254385B51F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1676898185; bh=uyDb9y+YgBjUpUJi/AOGtoCsdyATK0jemEN/WCdA84g=; h=From:To:Subject:Date:From; b=BSx9F7vY95V3GZSw/U7DPE1k5ou6/hBfmAK5sc9PxI0PC+xnYfssQo5g2u4rmYLr7 22+hnbGSJGiDc/J5rl0DtRf0BAJV3p2dZIskB1neumjzMPoAQLNRelWHjbA461aZGt 1t6fHWt2se6p351VVq+cWP1RlsmskoEYpvlB/ZL4= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/release/2.34/master] stdlib: Undo post review change to 16adc58e73f3 [BZ #27749] X-Act-Checkin: glibc X-Git-Author: Vitaly Buka X-Git-Refname: refs/heads/release/2.34/master X-Git-Oldrev: 2d7550e6cfff541380d3a1f2ac33e76aaf1273de X-Git-Newrev: 16c6a89c177fc5e4ef52a3ce0b5547030e68c94b Message-Id: <20230220130305.D6254385B51F@sourceware.org> Date: Mon, 20 Feb 2023 13:03:05 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=16c6a89c177fc5e4ef52a3ce0b5547030e68c94b commit 16c6a89c177fc5e4ef52a3ce0b5547030e68c94b Author: Vitaly Buka Date: Sat Feb 18 12:53:41 2023 -0800 stdlib: Undo post review change to 16adc58e73f3 [BZ #27749] Post review removal of "goto restart" from https://sourceware.org/pipermail/libc-alpha/2021-April/125470.html introduced a bug when some atexit handers skipped. Signed-off-by: Vitaly Buka Reviewed-by: Adhemerval Zanella (cherry picked from commit fd78cfa72ea2bab30fdb4e1e0672b34471426c05) Diff: --- stdlib/Makefile | 1 + stdlib/exit.c | 7 ++-- stdlib/test-atexit-recursive.c | 75 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 81 insertions(+), 2 deletions(-) diff --git a/stdlib/Makefile b/stdlib/Makefile index e13f1ee33c..3375da0a93 100644 --- a/stdlib/Makefile +++ b/stdlib/Makefile @@ -73,6 +73,7 @@ tests := \ test-a64l \ test-at_quick_exit-race \ test-atexit-race \ + test-atexit-recursive \ test-bz22786 \ test-canon \ test-canon2 \ diff --git a/stdlib/exit.c b/stdlib/exit.c index 453eb85be3..546343f7d4 100644 --- a/stdlib/exit.c +++ b/stdlib/exit.c @@ -53,7 +53,10 @@ __run_exit_handlers (int status, struct exit_function_list **listp, exit (). */ while (true) { - struct exit_function_list *cur = *listp; + struct exit_function_list *cur; + + restart: + cur = *listp; if (cur == NULL) { @@ -118,7 +121,7 @@ __run_exit_handlers (int status, struct exit_function_list **listp, if (__glibc_unlikely (new_exitfn_called != __new_exitfn_called)) /* The last exit function, or another thread, has registered more exit functions. Start the loop over. */ - continue; + goto restart; } *listp = cur->next; diff --git a/stdlib/test-atexit-recursive.c b/stdlib/test-atexit-recursive.c new file mode 100644 index 0000000000..0596b9763b --- /dev/null +++ b/stdlib/test-atexit-recursive.c @@ -0,0 +1,75 @@ +/* Support file for atexit/exit, etc. race tests (BZ #27749). + Copyright (C) 2023 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +/* Check that atexit handler registed from another handler still called. */ + +#include +#include +#include +#include +#include +#include + +static void +atexit_cb (void) +{ +} + +static void +atexit_last (void) +{ + _exit (1); +} + +static void +atexit_recursive (void) +{ + atexit (&atexit_cb); + atexit (&atexit_last); +} + +_Noreturn static void +test_and_exit (int count) +{ + for (int i = 0; i < count; ++i) + atexit (&atexit_cb); + atexit (&atexit_recursive); + exit (0); +} + +static int +do_test (void) +{ + for (int i = 0; i < 100; ++i) + if (xfork () == 0) + test_and_exit (i); + + for (int i = 0; i < 100; ++i) + { + int status; + xwaitpid (0, &status, 0); + if (!WIFEXITED (status)) + FAIL_EXIT1 ("Failed iterations %d", i); + TEST_COMPARE (WEXITSTATUS (status), 1); + } + + return 0; +} + +#define TEST_FUNCTION do_test +#include