public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] arm: Remove __builtin_arm_uqsub8 usage on string-fza.h
Date: Thu,  2 Mar 2023 20:19:21 +0000 (GMT)	[thread overview]
Message-ID: <20230302201921.256B1385843E@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=3a4781c16c680a2c5ab4585b4696f781898ab610

commit 3a4781c16c680a2c5ab4585b4696f781898ab610
Author: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Date:   Tue Feb 28 15:23:25 2023 -0300

    arm: Remove __builtin_arm_uqsub8 usage on string-fza.h
    
    The __builtin_arm_uqsub8 is an internal GCC builtin which might change
    in future release (the correct way is to include "arm_acle.h" and use
    __uqsub8 ()).  Since not all compilers support it, just use the
    inline assembler instead.
    
    Checked on armv7a-linux-gnueabihf.
    Reviewed-by: Wilco Dijkstra  <Wilco.Dijkstra@arm.com>

Diff:
---
 sysdeps/arm/armv6t2/string-fza.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/sysdeps/arm/armv6t2/string-fza.h b/sysdeps/arm/armv6t2/string-fza.h
index d85ce86434..fb75011991 100644
--- a/sysdeps/arm/armv6t2/string-fza.h
+++ b/sysdeps/arm/armv6t2/string-fza.h
@@ -33,13 +33,9 @@ find_zero_all (op_t x)
   /* Use unsigned saturated subtraction from 1 in each byte.
      That leaves 1 for every byte that was zero.  */
   op_t ones = repeat_bytes (0x01);
-#if __GNUC_PREREQ (10, 0)
-  return __builtin_arm_uqsub8 (ones, x);
-#else
   op_t ret;
   asm ("uqsub8 %0,%1,%2" : "=r"(ret) : "r"(ones), "r"(x));
   return ret;
-#endif
 }
 
 /* Identify bytes that are equal between X1 and X2.  */

                 reply	other threads:[~2023-03-02 20:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230302201921.256B1385843E@sourceware.org \
    --to=azanella@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).