public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Szabolcs Nagy <nsz@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/arm/morello/main] TODO(vdso): aarch64: morello: disable VDSO loading
Date: Fri,  3 Mar 2023 09:58:14 +0000 (GMT)	[thread overview]
Message-ID: <20230303095814.181723858C83@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=47e61ba7720c1c646077318e079dcb75224b1001

commit 47e61ba7720c1c646077318e079dcb75224b1001
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Tue Feb 21 16:47:37 2023 +0000

    TODO(vdso): aarch64: morello: disable VDSO loading
    
    Once the kernel starts providing a VDSO, old binaries should continue
    to work (without using the new VDSO).  For this we set the vdso to 0
    independently of auxv, otherwise glibc attempts to load it even if the
    target has no vdso symbols specified and the load can crash since the
    setup code is not purecap compatible.

Diff:
---
 sysdeps/unix/sysv/linux/aarch64/morello/dl-auxv.h | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/sysdeps/unix/sysv/linux/aarch64/morello/dl-auxv.h b/sysdeps/unix/sysv/linux/aarch64/morello/dl-auxv.h
new file mode 100644
index 0000000000..94669f975d
--- /dev/null
+++ b/sysdeps/unix/sysv/linux/aarch64/morello/dl-auxv.h
@@ -0,0 +1,21 @@
+/* Auxiliary vector processing.  Morello version.
+   Copyright (C) 2023 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+/* Disable VDSO loading even if Linux provides one as it may crash.  */
+#define DL_PLATFORM_AUXV \
+  GLRO(dl_sysinfo_dso) = 0;

                 reply	other threads:[~2023-03-03  9:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230303095814.181723858C83@sourceware.org \
    --to=nsz@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).