From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1895) id ED8EB385B53B; Wed, 8 Mar 2023 18:46:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ED8EB385B53B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1678301190; bh=cwRKImHRB/7+JUo48T50fljuYHn+DprJU++TmyfGJXE=; h=From:To:Subject:Date:From; b=LOXTY7j5c+i25yZgpMHeqK4XGzIJ6FBtY1cNNNxWj0wrKsVRVPxP5IfEKioFPXORX pIJNq0tr3pX+TjpbMtQ1f6pERYBZXN+k4a4/b0V2UMuvRxrkvZ8/ldVBqLUst+WEME x43HH2VlfepgZaQSclTxni3gl7Wm/KpNCDnWdIJc= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Wilco Dijkstra To: glibc-cvs@sourceware.org Subject: [glibc] Benchtests: Remove simple_strcpy_chk X-Act-Checkin: glibc X-Git-Author: Wilco Dijkstra X-Git-Refname: refs/heads/master X-Git-Oldrev: d1c3c0e4fefb92634fd2583d369cdb71b804e7a6 X-Git-Newrev: 73a284f618aa81d2bd1f93b299ac5dbf95f396b1 Message-Id: <20230308184630.ED8EB385B53B@sourceware.org> Date: Wed, 8 Mar 2023 18:46:30 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=73a284f618aa81d2bd1f93b299ac5dbf95f396b1 commit 73a284f618aa81d2bd1f93b299ac5dbf95f396b1 Author: Wilco Dijkstra Date: Fri Mar 3 12:44:46 2023 +0000 Benchtests: Remove simple_strcpy_chk Remove the slow byte oriented simple_strcpy_chk and simple_stpcpy_chk. Adjust iteration count to increase benchmark time. Reviewed-by: Adhemerval Zanella Diff: --- benchtests/bench-stpcpy_chk.c | 13 ------------- benchtests/bench-strcpy_chk.c | 15 +-------------- 2 files changed, 1 insertion(+), 27 deletions(-) diff --git a/benchtests/bench-stpcpy_chk.c b/benchtests/bench-stpcpy_chk.c index aaacd336ba..85d5a5e924 100644 --- a/benchtests/bench-stpcpy_chk.c +++ b/benchtests/bench-stpcpy_chk.c @@ -22,24 +22,11 @@ #include "bench-string.h" extern void __attribute__ ((noreturn)) __chk_fail (void); -char *simple_stpcpy_chk (char *, const char *, size_t); extern char *normal_stpcpy (char *, const char *, size_t) __asm ("stpcpy"); extern char *__stpcpy_chk (char *, const char *, size_t); -IMPL (simple_stpcpy_chk, 0) IMPL (normal_stpcpy, 1) IMPL (__stpcpy_chk, 2) -char * -simple_stpcpy_chk (char *dst, const char *src, size_t len) -{ - if (! len) - __chk_fail (); - while ((*dst++ = *src++) != '\0') - if (--len == 0) - __chk_fail (); - return dst - 1; -} - #include "bench-strcpy_chk.c" diff --git a/benchtests/bench-strcpy_chk.c b/benchtests/bench-strcpy_chk.c index 6fce90cc98..48ecaaf392 100644 --- a/benchtests/bench-strcpy_chk.c +++ b/benchtests/bench-strcpy_chk.c @@ -26,26 +26,13 @@ symbol, which is part of the public ABI and may be used externally. */ extern void __attribute__ ((noreturn)) __chk_fail (void); -char *simple_strcpy_chk (char *, const char *, size_t); extern char *normal_strcpy (char *, const char *, size_t) __asm ("strcpy"); extern char *__strcpy_chk (char *, const char *, size_t); -IMPL (simple_strcpy_chk, 0) IMPL (normal_strcpy, 1) IMPL (__strcpy_chk, 2) -char * -simple_strcpy_chk (char *dst, const char *src, size_t len) -{ - char *ret = dst; - if (! len) - __chk_fail (); - while ((*dst++ = *src++) != '\0') - if (--len == 0) - __chk_fail (); - return ret; -} #endif #include @@ -77,7 +64,7 @@ do_one_test (impl_t *impl, char *dst, const char *src, size_t len, size_t dlen) { char *res; - size_t i, iters = INNER_LOOP_ITERS8; + size_t i, iters = INNER_LOOP_ITERS_LARGE; timing_t start, stop, cur; if (dlen <= len)