From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1895) id 6678338582BE; Wed, 8 Mar 2023 18:46:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6678338582BE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1678301211; bh=55mBvpFqOoB+1x8AC6L0w60rO83uc8MJMuA+FmaIpSs=; h=From:To:Subject:Date:From; b=aw1RV7phgN+kmwtIDYzI9gd1GsoVkwn/aMqNIT5Y9ByHU7nVT7fbk6O0I4srIMqWm j2JqW4OdFVqrhF42A8ZzqbDYvPQtC1jBIzu2wVWz+g3I761hBaEPOIt8OTEboa/8B7 S/RmZTI95CefrXHIzKKOvpQZ+Jqj8FmMIGoq6fpw= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Wilco Dijkstra To: glibc-cvs@sourceware.org Subject: [glibc] Benchtests: Remove simple_memcmp X-Act-Checkin: glibc X-Git-Author: Wilco Dijkstra X-Git-Refname: refs/heads/master X-Git-Oldrev: 5de1508803bd1beeadd370ebac19e43b3232380b X-Git-Newrev: 183b425a05f421db0f21a9a81553816525fe93b9 Message-Id: <20230308184651.6678338582BE@sourceware.org> Date: Wed, 8 Mar 2023 18:46:51 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=183b425a05f421db0f21a9a81553816525fe93b9 commit 183b425a05f421db0f21a9a81553816525fe93b9 Author: Wilco Dijkstra Date: Fri Mar 3 13:04:00 2023 +0000 Benchtests: Remove simple_memcmp Remove the slow byte oriented simple_memcmp. Reviewed-by: Adhemerval Zanella Diff: --- benchtests/bench-memcmp.c | 32 +------------------------------- 1 file changed, 1 insertion(+), 31 deletions(-) diff --git a/benchtests/bench-memcmp.c b/benchtests/bench-memcmp.c index a937953065..4d2b8cbb30 100644 --- a/benchtests/bench-memcmp.c +++ b/benchtests/bench-memcmp.c @@ -19,46 +19,16 @@ #define TEST_MAIN #ifdef TEST_MEMCMPEQ # define TEST_NAME "__memcmpeq" -# define SIMPLE_MEMCMP simple_memcmpeq #elif defined WIDE # define TEST_NAME "wmemcmp" -# define SIMPLE_MEMCMP simple_wmemcmp #else # define TEST_NAME "memcmp" -# define SIMPLE_MEMCMP simple_memcmp #endif #include "bench-string.h" -#ifdef WIDE - -int -SIMPLE_MEMCMP (const wchar_t *s1, const wchar_t *s2, size_t n) -{ - int ret = 0; - /* Warning! - wmemcmp has to use SIGNED comparison for elements. - memcmp has to use UNSIGNED comparison for elemnts. - */ - while (n-- && (ret = *s1 < *s2 ? -1 : *s1 == *s2 ? 0 : 1) == 0) {s1++; s2++;} - return ret; -} -#else -# include - -int -SIMPLE_MEMCMP (const char *s1, const char *s2, size_t n) -{ - int ret = 0; - - while (n-- && (ret = *(unsigned char *) s1++ - *(unsigned char *) s2++) == 0); - return ret; -} -#endif - -# include "json-lib.h" +#include "json-lib.h" typedef int (*proto_t) (const CHAR *, const CHAR *, size_t); -IMPL (SIMPLE_MEMCMP, 0) IMPL (MEMCMP, 1) static void