From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1895) id 832A638582BE; Wed, 8 Mar 2023 18:46:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 832A638582BE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1678301216; bh=FMkyRnUUcTIcf5g6BDxS8Lb7wTJfuBhNAWr611Tt08U=; h=From:To:Subject:Date:From; b=icemUM4Sft635l/EZj2yMeRxi47BzQgg9h0USvpkHf/JmtBTZ/cXjsi0cU3vO456a LTsTawiAa7Yc63MXmRF7BOjKsFLQEFkrDf9WIPlbpnTVF1oyNjAoYAD+JqHDsP5YEF gM5vFxR2sr6Q/ZCJ5A5ndV4b86Y79aiaF9BS6g0c= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Wilco Dijkstra To: glibc-cvs@sourceware.org Subject: [glibc] Benchtests: Remove simple_str(n)casecmp X-Act-Checkin: glibc X-Git-Author: Wilco Dijkstra X-Git-Refname: refs/heads/master X-Git-Oldrev: 183b425a05f421db0f21a9a81553816525fe93b9 X-Git-Newrev: 9ab7c42387409d5cf8facd0a56cfd98ce55b8cc3 Message-Id: <20230308184656.832A638582BE@sourceware.org> Date: Wed, 8 Mar 2023 18:46:56 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9ab7c42387409d5cf8facd0a56cfd98ce55b8cc3 commit 9ab7c42387409d5cf8facd0a56cfd98ce55b8cc3 Author: Wilco Dijkstra Date: Fri Mar 3 13:21:05 2023 +0000 Benchtests: Remove simple_str(n)casecmp Remove the slow byte oriented loops. Adjust iteration count to reduce benchmark time. Reviewed-by: Adhemerval Zanella Diff: --- benchtests/bench-strcasecmp.c | 16 +--------------- benchtests/bench-strncasecmp.c | 23 +---------------------- 2 files changed, 2 insertions(+), 37 deletions(-) diff --git a/benchtests/bench-strcasecmp.c b/benchtests/bench-strcasecmp.c index fcfffdea42..abc6a216e3 100644 --- a/benchtests/bench-strcasecmp.c +++ b/benchtests/bench-strcasecmp.c @@ -23,28 +23,14 @@ #include "json-lib.h" typedef int (*proto_t) (const char *, const char *); -static int simple_strcasecmp (const char *, const char *); -IMPL (simple_strcasecmp, 0) IMPL (strcasecmp, 1) -static int -simple_strcasecmp (const char *s1, const char *s2) -{ - int ret; - - while ((ret = ((unsigned char) tolower (*s1) - - (unsigned char) tolower (*s2))) == 0 - && *s1++) - ++s2; - return ret; -} - static void do_one_test (json_ctx_t *json_ctx, impl_t *impl, const char *s1, const char *s2, int exp_result) { - size_t i, iters = INNER_LOOP_ITERS; + size_t i, iters = INNER_LOOP_ITERS8; timing_t start, stop, cur; int result = CALL (impl, s1, s2); if ((exp_result == 0 && result != 0) diff --git a/benchtests/bench-strncasecmp.c b/benchtests/bench-strncasecmp.c index 5689a22901..051c17d9f7 100644 --- a/benchtests/bench-strncasecmp.c +++ b/benchtests/bench-strncasecmp.c @@ -23,35 +23,14 @@ #include "json-lib.h" typedef int (*proto_t) (const char *, const char *, size_t); -static int simple_strncasecmp (const char *, const char *, size_t); -IMPL (simple_strncasecmp, 0) IMPL (strncasecmp, 1) -static int -simple_strncasecmp (const char *s1, const char *s2, size_t n) -{ - int ret; - - if (n == 0) - return 0; - - while ((ret = ((unsigned char) tolower (*s1) - - (unsigned char) tolower (*s2))) == 0 - && *s1++) - { - if (--n == 0) - return 0; - ++s2; - } - return ret; -} - static void do_one_test (json_ctx_t *json_ctx, impl_t *impl, const char *s1, const char *s2, size_t n, int exp_result) { - size_t i, iters = INNER_LOOP_ITERS; + size_t i, iters = INNER_LOOP_ITERS8; timing_t start, stop, cur; TIMING_NOW (start);