public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Yinyu Cai <caiyinyu@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] LoongArch: ldconfig: Add comments for using EF_LARCH_OBJABI_V1
Date: Tue, 28 Mar 2023 01:56:58 +0000 (GMT)	[thread overview]
Message-ID: <20230328015658.BC2373858D39@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=07dd75589ecbedec5162a5645d57f8bd093a45db

commit 07dd75589ecbedec5162a5645d57f8bd093a45db
Author: caiyinyu <caiyinyu@loongson.cn>
Date:   Tue Mar 28 09:19:53 2023 +0800

    LoongArch: ldconfig: Add comments for using EF_LARCH_OBJABI_V1
    
    We added Adhemerval Zanella's comment to explain the reason for
    using EF_LARCH_OBJABI_V1.

Diff:
---
 sysdeps/unix/sysv/linux/loongarch/readelflib.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/sysdeps/unix/sysv/linux/loongarch/readelflib.c b/sysdeps/unix/sysv/linux/loongarch/readelflib.c
index ceba355959..e34612895d 100644
--- a/sysdeps/unix/sysv/linux/loongarch/readelflib.c
+++ b/sysdeps/unix/sysv/linux/loongarch/readelflib.c
@@ -40,6 +40,12 @@ process_elf_file (const char *file_name, const char *lib, int *flag,
 
   ret = process_elf64_file (file_name, lib, flag, isa_level, soname,
 				file_contents, file_length);
+
+  /* The EF_LARCH_OBJABI_V1 flag indicate which set of static relocations
+   the object might use and it only considered during static linking,
+   it does not reflect in runtime relocations.  However some binutils
+   version might set it on dynamic shared object, so clear it to avoid
+   see the SO as unsupported.  */
   flags = elf64_header->e_flags & ~EF_LARCH_OBJABI_V1;
 
   /* LoongArch linkers encode the floating point ABI as part of the ELF headers.  */

                 reply	other threads:[~2023-03-28  1:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230328015658.BC2373858D39@sourceware.org \
    --to=caiyinyu@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).