public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Samuel Thibault <sthibaul@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] stdio-common: Fix building when !IS_IN (libc)
Date: Sun,  2 Apr 2023 23:28:14 +0000 (GMT)	[thread overview]
Message-ID: <20230402232814.8CC6A3858409@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=589bcfdeefeba493fd0f90fbdcbd285ec1ed313d

commit 589bcfdeefeba493fd0f90fbdcbd285ec1ed313d
Author: Sergey Bugaev <bugaevc@gmail.com>
Date:   Sun Mar 19 18:09:53 2023 +0300

    stdio-common: Fix building when !IS_IN (libc)
    
    In this case, _itoa_word () is already defined inline in the header (see
    sysdeps/generic/_itoa.h), and the second definition causes an error.
    
    Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
    Message-Id: <20230319151017.531737-11-bugaevc@gmail.com>

Diff:
---
 stdio-common/_itoa.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/stdio-common/_itoa.c b/stdio-common/_itoa.c
index 27285193bc..3037b0f529 100644
--- a/stdio-common/_itoa.c
+++ b/stdio-common/_itoa.c
@@ -157,6 +157,7 @@ const struct base_table_t _itoa_base_table[] attribute_hidden =
 };
 #endif
 
+#if IS_IN (libc)
 char *
 _itoa_word (_ITOA_WORD_TYPE value, char *buflim,
 	    unsigned int base, int upper_case)
@@ -185,6 +186,7 @@ _itoa_word (_ITOA_WORD_TYPE value, char *buflim,
   return buflim;
 }
 #undef SPECIAL
+#endif /* IS_IN (libc) */
 
 
 #if _ITOA_NEEDED

                 reply	other threads:[~2023-04-02 23:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230402232814.8CC6A3858409@sourceware.org \
    --to=sthibaul@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).