From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1792) id D0252385840F; Sun, 2 Apr 2023 23:29:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D0252385840F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1680478150; bh=omiBncssmdZCJoPEhBPRyTbBP5c3GRZJl7PYO4boXEs=; h=From:To:Subject:Date:From; b=W1qOsk4aUMwIYvRgZrWLnRqu9uelLzb6fRvo+0JDkMK+uyI/0vBW/bHu778fqpOGL qC2KtqyZmKGGWuqBcEuv5PhQMExLsenkFuq2MQtaLYtmdjvpLTgdpyyaqncPVVUrYJ UnWmWCbcE2iJzMiGNvGIRMxBQKg/w9rGDrA+O2EI= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Samuel Thibault To: glibc-cvs@sourceware.org Subject: [glibc] hurd: Microoptimize _hurd_self_sigstate () X-Act-Checkin: glibc X-Git-Author: Sergey Bugaev X-Git-Refname: refs/heads/master X-Git-Oldrev: 17841fa7d45c7ce8836a2935255f90f0bfac46b1 X-Git-Newrev: 7b3d8558d92a123743699c577704aab4a2f3d949 Message-Id: <20230402232910.D0252385840F@sourceware.org> Date: Sun, 2 Apr 2023 23:29:10 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=7b3d8558d92a123743699c577704aab4a2f3d949 commit 7b3d8558d92a123743699c577704aab4a2f3d949 Author: Sergey Bugaev Date: Sun Mar 19 18:10:14 2023 +0300 hurd: Microoptimize _hurd_self_sigstate () When THREAD_GETMEM is defined with inline assembly, the compiler may not optimize away the two reads of _hurd_sigstate. Help it out a little bit by only reading it once. This also makes for a slightly cleaner code. Signed-off-by: Sergey Bugaev Message-Id: <20230319151017.531737-32-bugaevc@gmail.com> Diff: --- hurd/hurd/signal.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hurd/hurd/signal.h b/hurd/hurd/signal.h index c33f974b1b..662e955e94 100644 --- a/hurd/hurd/signal.h +++ b/hurd/hurd/signal.h @@ -166,13 +166,15 @@ extern void _hurd_sigstate_delete (thread_t thread); _HURD_SIGNAL_H_EXTERN_INLINE struct hurd_sigstate * _hurd_self_sigstate (void) { - if (THREAD_GETMEM (THREAD_SELF, _hurd_sigstate) == NULL) + struct hurd_sigstate *ss = THREAD_GETMEM (THREAD_SELF, _hurd_sigstate); + if (__glibc_unlikely (ss == NULL)) { thread_t self = __mach_thread_self (); - THREAD_SETMEM (THREAD_SELF, _hurd_sigstate, _hurd_thread_sigstate (self)); + ss = _hurd_thread_sigstate (self); + THREAD_SETMEM (THREAD_SELF, _hurd_sigstate, ss); __mach_port_deallocate (__mach_task_self (), self); } - return THREAD_GETMEM (THREAD_SELF, _hurd_sigstate); + return ss; } # endif #endif