public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc] inet/rcmd.c: fix warn unused result Date: Tue, 18 Apr 2023 13:01:28 +0000 (GMT) [thread overview] Message-ID: <20230418130128.C910D3858425@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=1629adf2a6eefe5ddddc2445e2d056ca80edfe8b commit 1629adf2a6eefe5ddddc2445e2d056ca80edfe8b Author: Frédéric Bérat <fberat@redhat.com> Date: Tue Apr 18 09:01:00 2023 -0400 inet/rcmd.c: fix warn unused result Fix unused result warnings, detected when _FORTIFY_SOURCE is enabled in glibc. Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org> Diff: --- inet/rcmd.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/inet/rcmd.c b/inet/rcmd.c index ad8a894907..c1cd9daeb5 100644 --- a/inet/rcmd.c +++ b/inet/rcmd.c @@ -561,7 +561,9 @@ ruserok2_sa (struct sockaddr *ra, size_t ralen, int superuser, reading an NFS mounted file system, can't read files that are protected read/write owner only. */ uid = __geteuid (); - seteuid (pwd->pw_uid); + if (seteuid (pwd->pw_uid) < 0) + return -1; + hostf = iruserfopen (pbuf, pwd->pw_uid); if (hostf != NULL) @@ -570,7 +572,8 @@ ruserok2_sa (struct sockaddr *ra, size_t ralen, int superuser, fclose (hostf); } - seteuid (uid); + if (seteuid (uid) < 0) + return -1; return isbad; } return -1;
reply other threads:[~2023-04-18 13:01 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230418130128.C910D3858425@sourceware.org \ --to=siddhesh@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).