From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2206) id C910D3858425; Tue, 18 Apr 2023 13:01:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C910D3858425 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1681822888; bh=Ff/knOz0NTZ0Oo26bK4TslEct00kh03RU+ppRVB0Nss=; h=From:To:Subject:Date:From; b=vK1X9S2ySqoO3GeAhbnpoO841jzh/XCkFOkLclZ8qny2KnRYsMns7jIf47CbbpRAh rbmFFLmKSBB+OkETNkszp+urNPNh5/0bYMKTUN8QuEgTluConVGPzzztoKAcU6c4b1 S7uQhPt16NnpWg//z3/MAv8/8ACwgQC6cZt9RVeM= MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" From: Siddhesh Poyarekar To: glibc-cvs@sourceware.org Subject: [glibc] inet/rcmd.c: fix warn unused result X-Act-Checkin: glibc X-Git-Author: =?utf-8?b?RnLDqWTDqXJpYyBCw6lyYXQ=?= X-Git-Refname: refs/heads/master X-Git-Oldrev: cb9cae962c315139941a6eb0d07c6a71b658f5bb X-Git-Newrev: 1629adf2a6eefe5ddddc2445e2d056ca80edfe8b Message-Id: <20230418130128.C910D3858425@sourceware.org> Date: Tue, 18 Apr 2023 13:01:28 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=1629adf2a6eefe5ddddc2445e2d056ca80edfe8b commit 1629adf2a6eefe5ddddc2445e2d056ca80edfe8b Author: Frédéric Bérat Date: Tue Apr 18 09:01:00 2023 -0400 inet/rcmd.c: fix warn unused result Fix unused result warnings, detected when _FORTIFY_SOURCE is enabled in glibc. Reviewed-by: Siddhesh Poyarekar Diff: --- inet/rcmd.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/inet/rcmd.c b/inet/rcmd.c index ad8a894907..c1cd9daeb5 100644 --- a/inet/rcmd.c +++ b/inet/rcmd.c @@ -561,7 +561,9 @@ ruserok2_sa (struct sockaddr *ra, size_t ralen, int superuser, reading an NFS mounted file system, can't read files that are protected read/write owner only. */ uid = __geteuid (); - seteuid (pwd->pw_uid); + if (seteuid (pwd->pw_uid) < 0) + return -1; + hostf = iruserfopen (pbuf, pwd->pw_uid); if (hostf != NULL) @@ -570,7 +572,8 @@ ruserok2_sa (struct sockaddr *ra, size_t ralen, int superuser, fclose (hostf); } - seteuid (uid); + if (seteuid (uid) < 0) + return -1; return isbad; } return -1;