public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Rajalakshmi Srinivasaraghavan <raji@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] powerpc:GCC(<10) doesn't allow -mlong-double-64 after -mabi=ieeelongdouble
Date: Fri, 19 May 2023 22:35:20 +0000 (GMT)	[thread overview]
Message-ID: <20230519223520.405C93858C41@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=36cc908ed549389713955093bbfeaa35fdaf3e2e

commit 36cc908ed549389713955093bbfeaa35fdaf3e2e
Author: Mahesh Bodapati <mahesh.bodapati@ibm.com>
Date:   Fri May 12 05:22:59 2023 -0500

    powerpc:GCC(<10) doesn't allow -mlong-double-64 after -mabi=ieeelongdouble
    
    Removed -mabi=ieeelongdouble on failing tests. It resolves the error.
    error: ‘-mabi=ieeelongdouble’ requires ‘-mlong-double-128’

Diff:
---
 sysdeps/powerpc/powerpc64/le/Makefile | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/sysdeps/powerpc/powerpc64/le/Makefile b/sysdeps/powerpc/powerpc64/le/Makefile
index 53644d50cc..5214eb40ad 100644
--- a/sysdeps/powerpc/powerpc64/le/Makefile
+++ b/sysdeps/powerpc/powerpc64/le/Makefile
@@ -158,6 +158,23 @@ ifeq ($(subdir),stdio-common)
 CFLAGS-printf_fp.c = $(type-float128-CFLAGS)
 CFLAGS-printf_fphex.c = $(type-float128-CFLAGS)
 CFLAGS-printf_size.c = $(type-float128-CFLAGS)
+#Older GCC (<10) doesn't like -mabi=ieeelongdouble and -mlong-double-64.
+$(foreach suf,$(all-object-suffixes),\
+         $(objpfx)tst-nldbl-scanf-binary-c11$(suf) \
+         $(objpfx)tst-nldbl-scanf-binary-c2x$(suf) \
+         $(objpfx)tst-nldbl-scanf-binary-gnu11$(suf) \
+         $(objpfx)tst-nldbl-scanf-binary-gnu89$(suf) \
+         ): sysdep-CFLAGS := $(filter-out -mabi=ieeelongdouble,$(sysdep-CFLAGS))
+endif
+
+#Older GCC (<10) doesn't like -mabi=ieeelongdouble and -mlong-double-64.
+ifeq ($(subdir), wcsmbs)
+$(foreach suf,$(all-object-suffixes),\
+         $(objpfx)tst-nldbl-wscanf-binary-c11$(suf) \
+         $(objpfx)tst-nldbl-wscanf-binary-c2x$(suf) \
+         $(objpfx)tst-nldbl-wscanf-binary-gnu11$(suf) \
+         $(objpfx)tst-nldbl-wscanf-binary-gnu89$(suf) \
+         ): sysdep-CFLAGS := $(filter-out -mabi=ieeelongdouble,$(sysdep-CFLAGS))
 endif
 
 # Disable linker noise on files using ieee128 long double internally

                 reply	other threads:[~2023-05-19 22:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230519223520.405C93858C41@sourceware.org \
    --to=raji@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).