From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id 302943858C39; Mon, 12 Jun 2023 17:58:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 302943858C39 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1686592714; bh=x5/XJBP5n/AJjsIehprtpPDaTqkvyPLrIlq3k5lP1Qg=; h=From:To:Subject:Date:From; b=oPoitVEtZa4ufpJCzkPnJLz802xoUgfAqF1bSB1Q+MZoC9BijWLZD70pzwdtlZwmW 0BEf/FDSnJd2Kt5IT5bW4JhwYB8wPXUdyFda8SfvcbhIDhT62Vdig5IodPo/pih3MJ R6UIdm5qSYN6QuDWyEM0DGOgzHGtudfNvmD9XDqc= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc] malloc: Decrease resource usage for malloc tests X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella Netto X-Git-Refname: refs/heads/master X-Git-Oldrev: e6ce346d0791410a2e6ec9df1bc35e6acd4bca18 X-Git-Newrev: 94384bdf3955e59f508a6d927065fe0aa824d82b Message-Id: <20230612175834.302943858C39@sourceware.org> Date: Mon, 12 Jun 2023 17:58:34 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=94384bdf3955e59f508a6d927065fe0aa824d82b commit 94384bdf3955e59f508a6d927065fe0aa824d82b Author: Adhemerval Zanella Netto Date: Wed Jun 7 14:39:55 2023 -0300 malloc: Decrease resource usage for malloc tests The tst-mallocfork2 and tst-mallocfork3 create large number of subprocesss, around 11k for former and 20k for latter, to check for malloc async-signal-safeness on both fork and _Fork. However they do not really exercise allocation patterns different than other tests fro malloc itself, and the spawned process just exit without any extra computation. The tst-malloc-tcache-leak is similar, but creates 100k threads and already checks the resulting with mallinfo. These tests are also very sensitive to system load (since they estresss heavy the kernel resource allocation), and adding them on THP tunable and mcheck tests increase the pressure even more. For THP the fork tests do not add any more coverage than other tests. The mcheck is also not enable for tst-malloc-tcache-leak. Checked on x86_64-linux-gnu. Reviewed-by: Carlos O'Donell Diff: --- malloc/Makefile | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/malloc/Makefile b/malloc/Makefile index ce6ebcf1b3..c1db3347d8 100644 --- a/malloc/Makefile +++ b/malloc/Makefile @@ -74,7 +74,10 @@ test-srcs = tst-mtrace # with MALLOC_CHECK_=3 because they expect a specific failure. tests-exclude-malloc-check = tst-malloc-check tst-malloc-usable \ tst-mxfast tst-safe-linking \ - tst-compathooks-off tst-compathooks-on tst-memalign-2 tst-memalign-3 + tst-compathooks-off tst-compathooks-on tst-memalign-2 tst-memalign-3 \ + tst-mallocfork2 \ + tst-mallocfork3 \ + tst-malloc-tcache-leak # Run all tests with MALLOC_CHECK_=3 tests-malloc-check = $(filter-out $(tests-exclude-malloc-check) \ @@ -92,7 +95,10 @@ tests-exclude-hugetlb1 = \ tst-interpose-static-thread \ tst-malloc-usable \ tst-malloc-usable-tunables \ - tst-mallocstate + tst-mallocstate \ + tst-malloc-tcache-leak \ + tst-mallocfork2 \ + tst-mallocfork3 # The tst-free-errno relies on the used malloc page size to mmap an # overlapping region. tests-exclude-hugetlb2 = \ @@ -121,7 +127,9 @@ tests-exclude-mcheck = tst-mallocstate \ tst-compathooks-off tst-compathooks-on \ tst-memalign-2 \ tst-memalign-3 \ - tst-mxfast + tst-mxfast \ + tst-mallocfork2 \ + tst-mallocfork3 tests-mcheck = $(filter-out $(tests-exclude-mcheck) $(tests-static), $(tests)) endif @@ -182,14 +190,10 @@ $(objpfx)tst-malloc-fork-deadlock-malloc-check: $(shared-thread-library) $(objpfx)tst-malloc-stats-cancellation-malloc-check: $(shared-thread-library) $(objpfx)tst-malloc-thread-exit-malloc-hugetlb1: $(shared-thread-library) $(objpfx)tst-malloc-thread-fail-malloc-hugetlb1: $(shared-thread-library) -$(objpfx)tst-mallocfork2-malloc-hugetlb1: $(shared-thread-library) -$(objpfx)tst-mallocfork3-malloc-hugetlb1: $(shared-thread-library) $(objpfx)tst-malloc-fork-deadlock-malloc-hugetlb1: $(shared-thread-library) $(objpfx)tst-malloc-stats-cancellation-malloc-hugetlb1: $(shared-thread-library) $(objpfx)tst-malloc-thread-exit-malloc-hugetlb2: $(shared-thread-library) $(objpfx)tst-malloc-thread-fail-malloc-hugetlb2: $(shared-thread-library) -$(objpfx)tst-mallocfork2-malloc-hugetlb2: $(shared-thread-library) -$(objpfx)tst-mallocfork3-malloc-hugetlb2: $(shared-thread-library) $(objpfx)tst-malloc-fork-deadlock-malloc-hugetlb2: $(shared-thread-library) $(objpfx)tst-malloc-stats-cancellation-malloc-hugetlb2: $(shared-thread-library) @@ -344,14 +348,9 @@ $(objpfx)tst-dynarray-fail-mem.out: $(objpfx)tst-dynarray-fail.out $(objpfx)tst-malloc-tcache-leak: $(shared-thread-library) $(objpfx)tst-malloc_info: $(shared-thread-library) $(objpfx)tst-mallocfork2: $(shared-thread-library) -$(objpfx)tst-malloc-tcache-leak-mcheck: $(shared-thread-library) $(objpfx)tst-malloc_info-mcheck: $(shared-thread-library) -$(objpfx)tst-mallocfork2-mcheck: $(shared-thread-library) -$(objpfx)tst-malloc-tcache-leak-malloc-check: $(shared-thread-library) $(objpfx)tst-malloc_info-malloc-check: $(shared-thread-library) $(objpfx)tst-mallocfork2-malloc-check: $(shared-thread-library) -$(objpfx)tst-malloc-tcache-leak-malloc-hugetlb1: $(shared-thread-library) -$(objpfx)tst-malloc-tcache-leak-malloc-hugetlb2: $(shared-thread-library) $(objpfx)tst-malloc_info-malloc-hugetlb1: $(shared-thread-library) $(objpfx)tst-malloc_info-malloc-hugetlb2: $(shared-thread-library) $(objpfx)tst-memalign-3: $(shared-thread-library)