public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Andreas K. Huttel <dilfridge@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] nscd: cleanup obsolete _FORTIFY_SOURCE setting
Date: Tue, 25 Jul 2023 20:17:26 +0000 (GMT)	[thread overview]
Message-ID: <20230725201726.85F293857719@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5b61880ba3a0367f8969e028cb2cfe80d6eda8ab

commit 5b61880ba3a0367f8969e028cb2cfe80d6eda8ab
Author: Sam James <sam@gentoo.org>
Date:   Tue Jul 25 21:04:31 2023 +0100

    nscd: cleanup obsolete _FORTIFY_SOURCE setting
    
    This was added in 233399bce2e79e5af3b344782e9943d5f1a9cdcb just for warn_if_unused
    warnings rather than anything substantial.
    
    Now that we have a proper configure argument for F_S (--enable-fortify-source),
    just drop this entirely, to avoid conflicting with e.g. detected --enable-fortify-source
    finding F_S=3, then nscd's Makefile setting F_S=2, resulting in a build-failure
    because of the redefinition.
    
    Signed-off-by: Sam James <sam@gentoo.org>
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>
    Reviewed-by: Andreas K. Hüttel <dilfridge@gentoo.org>

Diff:
---
 nscd/Makefile | 2 --
 1 file changed, 2 deletions(-)

diff --git a/nscd/Makefile b/nscd/Makefile
index c2e70d33b7..2a0489f4cf 100644
--- a/nscd/Makefile
+++ b/nscd/Makefile
@@ -79,8 +79,6 @@ CFLAGS-nscd_gethst_r.c += -fexceptions
 CFLAGS-nscd_getai.c += -fexceptions
 CFLAGS-nscd_initgroups.c += -fexceptions
 
-CPPFLAGS-nscd += -D_FORTIFY_SOURCE=2
-
 ifeq (yesyes,$(have-fpie)$(build-shared))
 CFLAGS-nscd += $(pie-ccflag)
 endif

                 reply	other threads:[~2023-07-25 20:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230725201726.85F293857719@sourceware.org \
    --to=dilfridge@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).