From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id E70513857732; Wed, 26 Jul 2023 14:21:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E70513857732 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1690381314; bh=ryVZYQ6PWWsIlp+25KXkk/jRldkPUCA4cjpMPcG9KGs=; h=From:To:Subject:Date:From; b=NKKxUcLgFRGv0zbvRp+rG78d24YFe4bftfFrgehPQSae7cD6rqrrChuiLbzQFn3ze pGgKZUXg8DDBOgqaRb3pfs/+RvEbN2CzQnLcDzyoMELuTgKMcSOU/4WTGTPD3PZZg9 tKla3qjUbHKxeGQzVhOsTkE7QhtPwvvGCnKjBy1c= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc] sunrpc: Fix netname build with older gcc X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella Netto X-Git-Refname: refs/heads/master X-Git-Oldrev: 7dfa534ef07cffe9ddb2614e25fbb2e9ae193164 X-Git-Newrev: 0eb6b2725ba4aae73c03ac1f05c31cd2a073c99a Message-Id: <20230726142154.E70513857732@sourceware.org> Date: Wed, 26 Jul 2023 14:21:54 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=0eb6b2725ba4aae73c03ac1f05c31cd2a073c99a commit 0eb6b2725ba4aae73c03ac1f05c31cd2a073c99a Author: Adhemerval Zanella Netto Date: Mon Jul 24 14:15:23 2023 -0300 sunrpc: Fix netname build with older gcc The -Wformat-overflow was added by gcc 8. Reviewed-by: Carlos O'Donell Diff: --- sunrpc/netname.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sunrpc/netname.c b/sunrpc/netname.c index d9d82501b0..9e2f78329e 100644 --- a/sunrpc/netname.c +++ b/sunrpc/netname.c @@ -52,10 +52,14 @@ user2netname (char netname[MAXNETNAMELEN + 1], const uid_t uid, /* GCC with -Os or -O1 warns that sprint might overflow while handling dfltdom, however the above test does check if an overflow would happen. */ +#if __GNUC_PREREQ (8, 0) DIAG_PUSH_NEEDS_COMMENT; DIAG_IGNORE_NEEDS_COMMENT (8, "-Wformat-overflow"); +#endif sprintf (netname, "%s.%d@%s", OPSYS, uid, dfltdom); +#if __GNUC_PREREQ (8, 0) DIAG_POP_NEEDS_COMMENT; +#endif i = strlen (netname); if (netname[i - 1] == '.') netname[i - 1] = '\0';