public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Florian Weimer <fw@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] hurd: Do not include full <stdarg.h> in <hurd.h>
Date: Thu,  3 Aug 2023 08:26:46 +0000 (GMT)	[thread overview]
Message-ID: <20230803082646.E5F433858426@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d97a12704bca5c2c326d856a69cd847c89784ae9

commit d97a12704bca5c2c326d856a69cd847c89784ae9
Author: Florian Weimer <fweimer@redhat.com>
Date:   Mon Jul 31 12:38:12 2023 +0200

    hurd: Do not include full <stdarg.h> in <hurd.h>
    
    This fixes a hurd/check-installed-headers-c failure with
    -std=c89 #define _FORTIFY_SOURCE 1:
    
    In file included from ../hurd/hurd.h:354,
                     from ../sysdeps/hurd/include/hurd.h:2,
                     from /tmp/cih_test_9IaUwa.c:10:
    /home/bmg/install/compilers/i686-gnu/lib/gcc/i686-glibc-gnu/13.2.1/include/stdarg.h:54:34: error: "__STDC_VERSION__" is not defined, evaluates to 0 [-Werror=undef]
       54 | #if !defined(__STRICT_ANSI__) || __STDC_VERSION__ + 0 >= 199900L \
          |                                  ^~~~~~~~~~~~~~~~
    /home/bmg/install/compilers/i686-gnu/lib/gcc/i686-glibc-gnu/13.2.1/include/stdarg.h:55:8: error: "__cplusplus" is not defined, evaluates to 0 [-Werror=undef]
       55 |     || __cplusplus + 0 >= 201103L
          |        ^~~~~~~~~~~
    cc1: all warnings being treated as errors
    
    Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Diff:
---
 hurd/hurd.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hurd/hurd.h b/hurd/hurd.h
index 06f00e93d6..a38e665676 100644
--- a/hurd/hurd.h
+++ b/hurd/hurd.h
@@ -350,12 +350,12 @@ extern int hurd_check_cancel (void);
 
 extern io_t __getdport (int fd), getdport (int fd);
 
-
+#define __need___va_list
 #include <stdarg.h>
 
 /* Write formatted output to PORT, a Mach port supporting the i/o protocol,
    according to the format string FORMAT, using the argument list in ARG.  */
-int vpprintf (io_t port, const char *format, va_list arg);
+int vpprintf (io_t port, const char *format, __gnuc_va_list arg);
 
 
 #endif	/* hurd.h */

                 reply	other threads:[~2023-08-03  8:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230803082646.E5F433858426@sourceware.org \
    --to=fw@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).