From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7844) id A8E703858D20; Fri, 11 Aug 2023 20:33:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A8E703858D20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1691786013; bh=6gQBscgDnp779/+3cu4LxAAPmN7BQCjUEk0CEjgdo1o=; h=From:To:Subject:Date:From; b=iYPLnb1U+nMBKxZM4yjidv8VBaEXRypREs/fgPXy+8hrLkSElKCOtBbHUa2XoAfzD UCGU0zEBmpIrn0WzxS1bQykdk+xEvvez4QDaPTxrSvp7Cx1ubGrgOZALpAmFPjuZeJ ZJ/sLY3yYBexB6/bNVvQazHFutzcHOIjBPueICHg= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Noah Goldstein To: glibc-cvs@sourceware.org Subject: [glibc] x86: Fix incorrect scope of setting `shared_per_thread` [BZ# 30745] X-Act-Checkin: glibc X-Git-Author: Noah Goldstein X-Git-Refname: refs/heads/master X-Git-Oldrev: f6b10ed8e9a00de49d0951e760cc2b5288862b47 X-Git-Newrev: 084fb31bc2c5f95ae0b9e6df4d3cf0ff43471ede Message-Id: <20230811203333.A8E703858D20@sourceware.org> Date: Fri, 11 Aug 2023 20:33:33 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=084fb31bc2c5f95ae0b9e6df4d3cf0ff43471ede commit 084fb31bc2c5f95ae0b9e6df4d3cf0ff43471ede Author: Noah Goldstein Date: Thu Aug 10 19:28:24 2023 -0500 x86: Fix incorrect scope of setting `shared_per_thread` [BZ# 30745] The: ``` if (shared_per_thread > 0 && threads > 0) shared_per_thread /= threads; ``` Code was accidentally moved to inside the else scope. This doesn't match how it was previously (before af992e7abd). This patch fixes that by putting the division after the `else` block. Diff: --- sysdeps/x86/dl-cacheinfo.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sysdeps/x86/dl-cacheinfo.h b/sysdeps/x86/dl-cacheinfo.h index 285773039f..5ddb35c9d9 100644 --- a/sysdeps/x86/dl-cacheinfo.h +++ b/sysdeps/x86/dl-cacheinfo.h @@ -770,11 +770,10 @@ get_common_cache_info (long int *shared_ptr, long int * shared_per_thread_ptr, u level. */ threads = ((cpu_features->features[CPUID_INDEX_1].cpuid.ebx >> 16) & 0xff); - - /* Get per-thread size of highest level cache. */ - if (shared_per_thread > 0 && threads > 0) - shared_per_thread /= threads; } + /* Get per-thread size of highest level cache. */ + if (shared_per_thread > 0 && threads > 0) + shared_per_thread /= threads; } /* Account for non-inclusive L2 and L3 caches. */