From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7932) id 0A7F83858421; Mon, 14 Aug 2023 20:51:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0A7F83858421 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1692046310; bh=E5lSDwx0nLzEh2qLwydOWHEv/NdxSr5Kemf0zJQwciA=; h=From:To:Subject:Date:From; b=MUyf8Vi/+l2j+s/FeTZFnXVnLyakly2XBMjY+coaEf4l+a9wbjtRzEHFpb1uxTocl x4GEP7L6/bRuJPql+f0jDydVb6VNrqcAmIZuHm5HH13XJG811tLG0ag5asjrV7W4hQ yu6N5VJQU5RPlnSSfP0IZ3B/z9djh5vYF2VPhVbs= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Joe Simmons-Talbott To: glibc-cvs@sourceware.org Subject: [glibc] resolv/nss_dns/dns-host: Get rid of alloca. X-Act-Checkin: glibc X-Git-Author: Joe Simmons-Talbott X-Git-Refname: refs/heads/master X-Git-Oldrev: 1b214630ce6f7e0099b8b6f87246246739b079cf X-Git-Newrev: 648b832600e94c09e3cee2fa6d3c3684687505e4 Message-Id: <20230814205150.0A7F83858421@sourceware.org> Date: Mon, 14 Aug 2023 20:51:50 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=648b832600e94c09e3cee2fa6d3c3684687505e4 commit 648b832600e94c09e3cee2fa6d3c3684687505e4 Author: Joe Simmons-Talbott Date: Mon Aug 14 20:50:40 2023 +0000 resolv/nss_dns/dns-host: Get rid of alloca. Since the alloca is a small constant size use an array instead. Reviewed-by: Siddhesh Poyarekar Diff: --- resolv/nss_dns/dns-host.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resolv/nss_dns/dns-host.c b/resolv/nss_dns/dns-host.c index 1d60c51f5e..c8b77bbc35 100644 --- a/resolv/nss_dns/dns-host.c +++ b/resolv/nss_dns/dns-host.c @@ -378,6 +378,7 @@ _nss_dns_gethostbyname4_r (const char *name, struct gaih_addrtuple **pat, int *herrnop, int32_t *ttlp) { enum nss_status status = check_name (name, herrnop); + char tmp[NS_MAXDNAME]; if (status != NSS_STATUS_SUCCESS) return status; struct resolv_context *ctx = __resolv_context_get (); @@ -395,8 +396,7 @@ _nss_dns_gethostbyname4_r (const char *name, struct gaih_addrtuple **pat, */ if (strchr (name, '.') == NULL) { - char *tmp = alloca (NS_MAXDNAME); - const char *cp = __res_context_hostalias (ctx, name, tmp, NS_MAXDNAME); + const char *cp = __res_context_hostalias (ctx, name, tmp, sizeof (tmp)); if (cp != NULL) name = cp; }