From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id D93FB3830B6B; Wed, 30 Aug 2023 12:34:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D93FB3830B6B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1693398871; bh=yMlXo02jAquuiPoPUybbg9ESkUlcHKI03MnRTgEjRcg=; h=From:To:Subject:Date:From; b=bod5bCGsMCt9PpidVxUNf9RnoeVLewfj5sS88/6Hqmmk4XXIe5ugKFSGLaeMoKagi f4cLZrlmv6lk/ptVNf+9sUox08GVttvIlvSQbhBIlXf6flzeRPFp+J14xPYm0ASrUy 9w58tkMAXJyo3GBwp3nB/L0YftPW5fculXWrCeOw= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] x86: Remove __strstr_generic prototype X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/clang X-Git-Oldrev: 8b8dfbeabb6456486f7a6aae3989a6a38d6523cd X-Git-Newrev: db2f4c393fab892293e816c55492d9249bbdd7e6 Message-Id: <20230830123431.D93FB3830B6B@sourceware.org> Date: Wed, 30 Aug 2023 12:34:31 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=db2f4c393fab892293e816c55492d9249bbdd7e6 commit db2f4c393fab892293e816c55492d9249bbdd7e6 Author: Adhemerval Zanella Date: Mon Mar 14 18:27:33 2022 -0300 x86: Remove __strstr_generic prototype This is not really require and clang throws a attribute declaration must precede definition: ../sysdeps/x86_64/multiarch/strstr.c:37:54: error: attribute declaration must precede definition [-Werror,-Wignored-attributes] extern __typeof (__redirect_strstr) __strstr_generic attribute_hidden; ^ ./../include/libc-symbols.h:423:43: note: expanded from macro 'attribute_hidden' # define attribute_hidden __attribute__ ((visibility ("hidden"))) ^ ../string/strstr.c:76:1: note: previous definition is here STRSTR (const char *haystack, const char *needle) ^ ../sysdeps/x86_64/multiarch/strstr.c:27:16: note: expanded from macro 'STRSTR' #define STRSTR __strstr_generic ^ 1 error generated. Diff: --- sysdeps/x86_64/multiarch/strstr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sysdeps/x86_64/multiarch/strstr.c b/sysdeps/x86_64/multiarch/strstr.c index 750218ac3d..7c7a320f88 100644 --- a/sysdeps/x86_64/multiarch/strstr.c +++ b/sysdeps/x86_64/multiarch/strstr.c @@ -34,7 +34,6 @@ #include "string/strstr.c" extern __typeof (__redirect_strstr) __strstr_sse2_unaligned attribute_hidden; -extern __typeof (__redirect_strstr) __strstr_generic attribute_hidden; extern __typeof (__redirect_strstr) __strstr_avx512 attribute_hidden; #include "init-arch.h"