From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id 845B8385C6E2; Wed, 30 Aug 2023 12:35:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 845B8385C6E2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1693398912; bh=5AcjldHRAZnWJmMk5pykTem+JjuJ5lQzu1mNomgs6OE=; h=From:To:Subject:Date:From; b=RpskEeVFAiRZTQn9PJlsr5TCwSU8Pn5W+dL/hy/VF3MGYBsIagbvnoaargWhekvJx WHyq04eUBTchhm+eQCrmRY0LoB8pKN/iY3W6vvU1whbi+d+FjR1k1Ue5Q/VF65VlFo LFSp9FWcZnvNaKqu8RUMQFQY9Qw3JR1M2CEmK74k= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] elf: Supress clang -Wsometimes-uninitialized on _dl_debug_initialize X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/clang X-Git-Oldrev: 880438a144a72b9159d39ae30bf8d1e99ca8efc0 X-Git-Newrev: ffee48719c651943eabff43a5c4678f35e65cc9f Message-Id: <20230830123512.845B8385C6E2@sourceware.org> Date: Wed, 30 Aug 2023 12:35:12 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ffee48719c651943eabff43a5c4678f35e65cc9f commit ffee48719c651943eabff43a5c4678f35e65cc9f Author: Adhemerval Zanella Date: Wed Aug 24 12:25:05 2022 -0300 elf: Supress clang -Wsometimes-uninitialized on _dl_debug_initialize Clang issues an warning where variable 'r' is used uninitialized whenever 'if' condition is false. The _dl_debug_initialize is called for static case always with LM_ID_BASE (csu/libc-start.c and elf/dl-reloc-static-pie.c) and DL_NSS will be always larger than 1 for shared case. Diff: --- elf/dl-debug.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/elf/dl-debug.c b/elf/dl-debug.c index bd7b1cc8f7..db25438256 100644 --- a/elf/dl-debug.c +++ b/elf/dl-debug.c @@ -54,7 +54,15 @@ _dl_debug_update (Lmid_t ns) struct r_debug * _dl_debug_initialize (ElfW(Addr) ldbase, Lmid_t ns) { - struct r_debug_extended *r, **pp = NULL; + /* clang issues an warning where variable 'r' is used uninitialized whenever + 'if' condition is false. The _dl_debug_initialize is called for static + case always with LM_ID_BASE (csu/libc-start.c and + elf/dl-reloc-static-pie.c) and DL_NSS will be always larger than 1 for + shared case. */ + DIAG_PUSH_NEEDS_COMMENT_CLANG; + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wsometimes-uninitialized"); + struct r_debug_extended *r; + struct r_debug_extended **pp = NULL; if (ns == LM_ID_BASE) { @@ -81,6 +89,7 @@ _dl_debug_initialize (ElfW(Addr) ldbase, Lmid_t ns) r->base.r_version = 2; } } + DIAG_POP_NEEDS_COMMENT_CLANG; if (r->base.r_brk == 0) {