From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id 043B93855581; Wed, 30 Aug 2023 12:36:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 043B93855581 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1693398994; bh=1smu1q8xwYEUKc1f0e2ppFTKkbA8R726UybsGVEcEJg=; h=From:To:Subject:Date:From; b=Gxs6E1/rmuKbJ3e/Lq23Q0LOLnmWJqh6Acv7FYFlJTntq4pM7jtdDS90aPguP8Ht+ f3ZqBgyEAZ63dilbHfFVOVIRQXgJzSq91FcI53jAjXKM21LaGUlrAgVD3cH8ChjjnQ trgoG1dBzFUio0XXrvVv0YfTqNXbnJvpBMTGr/rQ= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] string: Use asm alias instead of symbol redirections for stpcpy and mempcpy X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/clang X-Git-Oldrev: e22e14174593dafe700d64946fc88242f2238703 X-Git-Newrev: 9a0fffedba777d58ff811042a762ddda0e94b748 Message-Id: <20230830123634.043B93855581@sourceware.org> Date: Wed, 30 Aug 2023 12:36:34 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9a0fffedba777d58ff811042a762ddda0e94b748 commit 9a0fffedba777d58ff811042a762ddda0e94b748 Author: Adhemerval Zanella Date: Tue Mar 15 08:41:43 2022 -0300 string: Use asm alias instead of symbol redirections for stpcpy and mempcpy Commit 939da411433 added symbols redirections to handle ISO C namespace, however some compiler does not support to redeclare the function prototype. Moving these defintions to exported header it not a good practice (it exposes a internal implementation and it would require to add macros to define it only internally). Instead this patch replaces the symbol redirections by direct asm aliases, as done to handle libcall generation done by compiler on some loop optimizations. The only issue is sparc binutils generates an extra __mempcpy plt not called anywhere in the code, which indicates a binutils issue (this is added in the localplt.data for now). Checked on most of affected ABIs. Diff: --- include/string.h | 4 ++-- sysdeps/unix/sysv/linux/sparc/sparc64/localplt.data | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/include/string.h b/include/string.h index 86d1fa4abe..27f4e6e563 100644 --- a/include/string.h +++ b/include/string.h @@ -179,8 +179,8 @@ extern __typeof (strsep) strsep attribute_hidden; && !defined NO_MEMPCPY_STPCPY_REDIRECT /* Redirect calls to __builtin_mempcpy and __builtin_stpcpy to call __mempcpy and __stpcpy if not inlined. */ -extern __typeof (mempcpy) mempcpy __asm__ ("__mempcpy"); -extern __typeof (stpcpy) stpcpy __asm__ ("__stpcpy"); +__asm__ ("mempcpy = __mempcpy"); +__asm__ ("stpcpy = __stpcpy"); #endif extern void *__memcpy_chk (void *__restrict __dest, diff --git a/sysdeps/unix/sysv/linux/sparc/sparc64/localplt.data b/sysdeps/unix/sysv/linux/sparc/sparc64/localplt.data index 15c0f8ccf7..e7ab61dcbe 100644 --- a/sysdeps/unix/sysv/linux/sparc/sparc64/localplt.data +++ b/sysdeps/unix/sysv/linux/sparc/sparc64/localplt.data @@ -17,4 +17,7 @@ libc.so: calloc libc.so: free libc.so: malloc libc.so: realloc +# Unreferenced PLT created by the symbols aliases used to redirect +# the compiler generated mempcpy/stpcyp calls done by builtin usage. +libc.so: __mempcpy libm.so: matherr