public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/azanella/clang] elf: Use volatile to set __rseq_size and __rseq_offset
Date: Wed, 30 Aug 2023 12:42:13 +0000 (GMT)	[thread overview]
Message-ID: <20230830124213.757923858407@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=262706b313386a963a7ec5afd3bab550add73732

commit 262706b313386a963a7ec5afd3bab550add73732
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Sun Apr 3 11:23:20 2022 -0300

    elf: Use volatile to set __rseq_size and __rseq_offset
    
    To avoid compiler to optimize them away.

Diff:
---
 sysdeps/nptl/dl-tls_init_tp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sysdeps/nptl/dl-tls_init_tp.c b/sysdeps/nptl/dl-tls_init_tp.c
index 2ed98c5a31..dfd8591575 100644
--- a/sysdeps/nptl/dl-tls_init_tp.c
+++ b/sysdeps/nptl/dl-tls_init_tp.c
@@ -107,7 +107,7 @@ __tls_init_tp (void)
       {
         /* We need a writable view of the variables.  They are in
            .data.relro and are not yet write-protected.  */
-        extern unsigned int size __asm__ ("__rseq_size");
+        extern volatile unsigned int size __asm__ ("__rseq_size");
         size = sizeof (pd->rseq_area);
       }
 
@@ -117,7 +117,7 @@ __tls_init_tp (void)
        all targets support __thread_pointer, so set __rseq_offset only
        if the rseq registration may have happened because RSEQ_SIG is
        defined.  */
-    extern ptrdiff_t offset __asm__ ("__rseq_offset");
+    extern volatile ptrdiff_t offset __asm__ ("__rseq_offset");
     offset = (char *) &pd->rseq_area - (char *) __thread_pointer ();
 #endif
   }

             reply	other threads:[~2023-08-30 12:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30 12:42 Adhemerval Zanella [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-04-17 20:13 Adhemerval Zanella
2024-04-02 15:59 Adhemerval Zanella
2024-02-09 17:37 Adhemerval Zanella
2024-02-07 14:12 Adhemerval Zanella
2024-01-29 18:03 Adhemerval Zanella
2023-12-21 18:59 Adhemerval Zanella
2023-09-28 17:57 Adhemerval Zanella
2023-02-09 19:54 Adhemerval Zanella
2022-10-28 17:47 Adhemerval Zanella
2022-10-04 13:05 Adhemerval Zanella
2022-06-09 21:26 Adhemerval Zanella
2022-06-09 13:22 Adhemerval Zanella
2022-06-03 14:12 Adhemerval Zanella
2022-05-13 14:26 Adhemerval Zanella
2022-05-12 19:39 Adhemerval Zanella
2022-05-10 18:30 Adhemerval Zanella
2022-04-29 14:10 Adhemerval Zanella
2022-04-04 13:00 Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230830124213.757923858407@sourceware.org \
    --to=azanella@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).