From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7844) id 1AE1B3858407; Tue, 12 Sep 2023 03:47:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1AE1B3858407 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1694490451; bh=WYYJSqGMx9UlrZ13Flls9fSh8CqFrsWCToou7kIo/18=; h=From:To:Subject:Date:From; b=MrqetnECtYfBw4n8554dZ0EDkB0d5vdCi/jfuQms8r6fPZ2urvxElRI0eqeEvHB9m F+V0bINUzmUbP1tpT9S6xaiuUDwbQy7Zw29n0swU60Tk9TdZYyfHfQ1zWsVH81Qxql 5S/rTWqkpagE0kTXNb8CYg5Wvt/LfgOKWqPDxSgs= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Noah Goldstein To: glibc-cvs@sourceware.org Subject: [glibc/release/2.33/master] x86: Fix slight bug in `shared_per_thread` cache size calculation. X-Act-Checkin: glibc X-Git-Author: Noah Goldstein X-Git-Refname: refs/heads/release/2.33/master X-Git-Oldrev: 5e2d2d7cbd32a148b660d40496e477271b2805d2 X-Git-Newrev: 31b06441f9f82be270b3fe486eaa76bd1d866477 Message-Id: <20230912034731.1AE1B3858407@sourceware.org> Date: Tue, 12 Sep 2023 03:47:31 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=31b06441f9f82be270b3fe486eaa76bd1d866477 commit 31b06441f9f82be270b3fe486eaa76bd1d866477 Author: Noah Goldstein Date: Mon Jul 17 23:14:33 2023 -0500 x86: Fix slight bug in `shared_per_thread` cache size calculation. After: ``` commit af992e7abdc9049714da76cae1e5e18bc4838fb8 Author: Noah Goldstein Date: Wed Jun 7 13:18:01 2023 -0500 x86: Increase `non_temporal_threshold` to roughly `sizeof_L3 / 4` ``` Split `shared` (cumulative cache size) from `shared_per_thread` (cache size per socket), the `shared_per_thread` *can* be slightly off from the previous calculation. Previously we added `core` even if `threads_l2` was invalid, and only used `threads_l2` to divide `core` if it was present. The changed version only included `core` if `threads_l2` was valid. This change restores the old behavior if `threads_l2` is invalid by adding the entire value of `core`. Reviewed-by: DJ Delorie (cherry picked from commit 47f747217811db35854ea06741be3685e8bbd44d) Diff: --- sysdeps/x86/dl-cacheinfo.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sysdeps/x86/dl-cacheinfo.h b/sysdeps/x86/dl-cacheinfo.h index 71326a604d..c885b23f7a 100644 --- a/sysdeps/x86/dl-cacheinfo.h +++ b/sysdeps/x86/dl-cacheinfo.h @@ -685,8 +685,8 @@ get_common_cache_info (long int *shared_ptr, long int * shared_per_thread_ptr, u /* Account for non-inclusive L2 and L3 caches. */ if (!inclusive_cache) { - if (threads_l2 > 0) - shared_per_thread += core / threads_l2; + long int core_per_thread = threads_l2 > 0 ? (core / threads_l2) : core; + shared_per_thread += core_per_thread; shared += core; }