public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/azanella/clang] Disable __USE_EXTERN_INLINES for clang
Date: Thu, 28 Sep 2023 17:49:10 +0000 (GMT)	[thread overview]
Message-ID: <20230928174910.AC27C394D8A6@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=6e102459e53135b42d7d6c16b2b87778f1c620ab

commit 6e102459e53135b42d7d6c16b2b87778f1c620ab
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Thu Oct 7 18:16:04 2021 -0700

    Disable __USE_EXTERN_INLINES for clang
    
    clang does not allow to redefine attributes after function declaration.
    Although it work for external usage, its breaks the build for internal
    symbol that glibc provides as optimization (for instance bsearch
    with stdlib-bsearch.h or __cmsg_nxthdr).
    
    Disable such optimization for clang while building glibc.

Diff:
---
 include/features.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/features.h b/include/features.h
index 7c51b4a2e4..a94fc1b3a4 100644
--- a/include/features.h
+++ b/include/features.h
@@ -515,7 +515,7 @@
 /* Decide whether we can define 'extern inline' functions in headers.  */
 #if __GNUC_PREREQ (2, 7) && defined __OPTIMIZE__ \
     && !defined __OPTIMIZE_SIZE__ && !defined __NO_INLINE__ \
-    && defined __extern_inline
+    && defined __extern_inline && !(defined __clang__ && defined _LIBC)
 # define __USE_EXTERN_INLINES	1
 #endif

             reply	other threads:[~2023-09-28 17:49 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-28 17:49 Adhemerval Zanella [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-02-09 17:28 Adhemerval Zanella
2024-02-07 14:04 Adhemerval Zanella
2024-01-29 17:54 Adhemerval Zanella
2023-12-21 18:50 Adhemerval Zanella
2023-08-30 12:33 Adhemerval Zanella
2023-02-09 19:45 Adhemerval Zanella
2022-10-28 17:38 Adhemerval Zanella
2022-10-04 12:55 Adhemerval Zanella
2022-06-09 21:17 Adhemerval Zanella
2022-06-09 13:14 Adhemerval Zanella
2022-06-03 14:03 Adhemerval Zanella
2022-05-13 14:17 Adhemerval Zanella
2022-05-12 19:31 Adhemerval Zanella
2022-05-10 18:21 Adhemerval Zanella
2022-04-29 14:01 Adhemerval Zanella
2022-04-04 12:51 Adhemerval Zanella
2022-03-31 19:04 Adhemerval Zanella
2022-03-29 20:27 Adhemerval Zanella
2022-03-16 17:58 Adhemerval Zanella
2022-03-15 18:36 Adhemerval Zanella
2022-03-11 17:20 Adhemerval Zanella
2022-03-08 18:57 Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230928174910.AC27C394D8A6@sourceware.org \
    --to=azanella@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).