public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/azanella/clang] configure: Fix check for -fno-tree-loop-distribute-patterns
Date: Thu, 28 Sep 2023 17:50:26 +0000 (GMT)	[thread overview]
Message-ID: <20230928175026.DF6AF3875DD6@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ffcaa3c6710fbaec084b8c66e3f480ef50aaf311

commit ffcaa3c6710fbaec084b8c66e3f480ef50aaf311
Author: Fangrui Song <maskray@google.com>
Date:   Sun Sep 26 00:15:23 2021 -0700

    configure: Fix check for -fno-tree-loop-distribute-patterns
    
    clang does not support -fno-tree-loop-distribute-patterns and using
    on __attribute__ ((__optimize__ (...))) only triggers a warning
    with AC_TRY_COMMAND.  Add -Werror so the tests fails if compiler
    does not support it.

Diff:
---
 configure    | 2 +-
 configure.ac | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 45ee893d49..85226db392 100755
--- a/configure
+++ b/configure
@@ -7402,7 +7402,7 @@ __attribute__ ((__optimize__ ("-fno-tree-loop-distribute-patterns")))
 foo (void) {}
 EOF
 libc_cv_cc_loop_to_function=no
-if { ac_try='${CC-cc} $CFLAGS $CPPFLAGS -c conftest.c'
+if { ac_try='${CC-cc} $CFLAGS $CPPFLAGS -Werror -c conftest.c'
   { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5
   (eval $ac_try) 2>&5
   ac_status=$?
diff --git a/configure.ac b/configure.ac
index 7a7fe4a28a..f508411c25 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1504,7 +1504,7 @@ __attribute__ ((__optimize__ ("-fno-tree-loop-distribute-patterns")))
 foo (void) {}
 EOF
 libc_cv_cc_loop_to_function=no
-if AC_TRY_COMMAND([${CC-cc} $CFLAGS $CPPFLAGS -c conftest.c])
+if AC_TRY_COMMAND([${CC-cc} $CFLAGS $CPPFLAGS -Werror -c conftest.c])
 then
   libc_cv_cc_loop_to_function=yes
 fi

             reply	other threads:[~2023-09-28 17:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-28 17:50 Adhemerval Zanella [this message]
2023-12-21 18:52 Adhemerval Zanella
2024-01-29 17:55 Adhemerval Zanella
2024-02-07 14:05 Adhemerval Zanella
2024-02-09 17:30 Adhemerval Zanella
2024-04-02 15:51 Adhemerval Zanella
2024-04-17 20:05 Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230928175026.DF6AF3875DD6@sourceware.org \
    --to=azanella@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).