public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Stefan Liebler <stli@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] tst-spawn-cgroup.c: Fix argument order of UNSUPPORTED message.
Date: Fri, 20 Oct 2023 06:46:41 +0000 (GMT)	[thread overview]
Message-ID: <20231020064641.547AE3858D1E@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f5677d9cebb12edcd9301dbb5cf40f82618b46af

commit f5677d9cebb12edcd9301dbb5cf40f82618b46af
Author: Stefan Liebler <stli@linux.ibm.com>
Date:   Thu Oct 19 14:35:59 2023 +0200

    tst-spawn-cgroup.c: Fix argument order of UNSUPPORTED message.
    
    The arguments for "expected" and "got" are mismatched.  Furthermore
    this patch is dumping both values as hex.
    Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
    Reviewed-by: Florian Weimer <fweimer@redhat.com>

Diff:
---
 sysdeps/unix/sysv/linux/tst-spawn-cgroup.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sysdeps/unix/sysv/linux/tst-spawn-cgroup.c b/sysdeps/unix/sysv/linux/tst-spawn-cgroup.c
index 84e24696eb..d947f6c7f3 100644
--- a/sysdeps/unix/sysv/linux/tst-spawn-cgroup.c
+++ b/sysdeps/unix/sysv/linux/tst-spawn-cgroup.c
@@ -136,9 +136,9 @@ create_new_cgroup (char **newcgroup)
     }
 
   if (!F_TYPE_EQUAL (fs.f_type, CGROUP2_SUPER_MAGIC))
-    FAIL_UNSUPPORTED ("%s is not a cgroupv2 (expected %jx, got %jd)",
-		      CGROUPFS, (intmax_t) fs.f_type,
-		      (intmax_t) CGROUP2_SUPER_MAGIC);
+    FAIL_UNSUPPORTED ("%s is not a cgroupv2 (expected %#jx, got %#jx)",
+		      CGROUPFS, (intmax_t) CGROUP2_SUPER_MAGIC,
+		      (intmax_t) fs.f_type);
 
   char *cgroup = get_cgroup ();
   TEST_VERIFY_EXIT (cgroup != NULL);

                 reply	other threads:[~2023-10-20  6:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231020064641.547AE3858D1E@sourceware.org \
    --to=stli@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).