From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7944) id DB2E83858C41; Tue, 14 Nov 2023 18:50:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DB2E83858C41 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1699987800; bh=ehDSGe9daOq1M76kNpwFcgllcQsDroSd8+p8bl9t/LM=; h=From:To:Subject:Date:From; b=uwdF70zTqw9EdAh72DR2C+lHxSybVXoyOWi11+teGgDV838/8IXTlTeqh7nrVPBR2 8ISOqzyanow/cO1dfR/qDIcyX1P+DfIYvLWiIUybkzBBM3ipkyXsyBLEUA+J0OAnWB 5eD0LKKC9ZwpAtsxOaLv7CRiWSoJmUUbvyE0J83M= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Pranav Kant To: glibc-cvs@sourceware.org Subject: [glibc/google/grte/v5-2.27/master] x86: Define __HAVE_FLOAT128 for Clang and use __builtin_*f128 code path X-Act-Checkin: glibc X-Git-Author: Fangrui Song X-Git-Refname: refs/heads/google/grte/v5-2.27/master X-Git-Oldrev: bade6276d16523f81a1dedf22e591730592f15d6 X-Git-Newrev: 2676793257d15138178c814e4f8ba75185e9b699 Message-Id: <20231114185000.DB2E83858C41@sourceware.org> Date: Tue, 14 Nov 2023 18:50:00 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=2676793257d15138178c814e4f8ba75185e9b699 commit 2676793257d15138178c814e4f8ba75185e9b699 Author: Fangrui Song Date: Sun Oct 10 14:38:00 2021 -0700 x86: Define __HAVE_FLOAT128 for Clang and use __builtin_*f128 code path Clang supports __builtin_fabsf128 (despite not supporting _Float128) but _not _builtin_fabsq. By falling back to `typedef __float128 _Float128;`, the float128 code will be buildable with Clang. Diff: --- sysdeps/x86/bits/floatn.h | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/sysdeps/x86/bits/floatn.h b/sysdeps/x86/bits/floatn.h index ed7bf122eb..7387bbae38 100644 --- a/sysdeps/x86/bits/floatn.h +++ b/sysdeps/x86/bits/floatn.h @@ -32,7 +32,8 @@ support, for x86_64 and x86. */ #if (defined __x86_64__ \ ? __GNUC_PREREQ (4, 3) \ - : (defined __GNU__ ? __GNUC_PREREQ (4, 5) : __GNUC_PREREQ (4, 4))) + : (defined __GNU__ ? __GNUC_PREREQ (4, 5) : __GNUC_PREREQ (4, 4))) \ + || defined __clang__ # define __HAVE_FLOAT128 1 #else # define __HAVE_FLOAT128 0 @@ -67,7 +68,8 @@ capture(i_have_distinct_float128, __HAVE_DISTINCT_FLOAT128); /* Defined to concatenate the literal suffix to be used with _Float128 types, if __HAVE_FLOAT128 is 1. */ # if __HAVE_FLOAT128 -# if !__GNUC_PREREQ (7, 0) || defined __cplusplus +# if !__GNUC_PREREQ (7, 0) || defined __cplusplus \ + || defined __clang__ /* The literal suffix f128 exists only since GCC 7.0. */ # define __f128(x) x##q # else @@ -77,7 +79,8 @@ capture(i_have_distinct_float128, __HAVE_DISTINCT_FLOAT128); /* Defined to a complex binary128 type if __HAVE_FLOAT128 is 1. */ # if __HAVE_FLOAT128 -# if !__GNUC_PREREQ (7, 0) || defined __cplusplus +# if !__GNUC_PREREQ (7, 0) || defined __cplusplus \ + || defined __clang__ /* Add a typedef for older GCC compilers which don't natively support _Complex _Float128. */ typedef _Complex float __cfloat128 __attribute__ ((__mode__ (__TC__))); @@ -91,8 +94,8 @@ typedef _Complex float __cfloat128 __attribute__ ((__mode__ (__TC__))); # if __HAVE_FLOAT128 /* The type _Float128 exists only since GCC 7.0. */ -# if !__GNUC_PREREQ (7, 0) || defined __cplusplus -/* need a clang 5.0 case here? */ +# if !__GNUC_PREREQ (7, 0) || defined __cplusplus \ + || defined __clang__ typedef __float128 _Float128; # endif @@ -112,7 +115,7 @@ typedef __float128 _Float128; #else /* GCC */ /* __builtin_huge_valf128 doesn't exist before GCC 7.0. */ -# if !__GNUC_PREREQ (7, 0) +# if !__GNUC_PREREQ (7, 0) && !defined __clang__ # define __builtin_huge_valf128() ((_Float128) __builtin_huge_val ()) # endif @@ -121,7 +124,7 @@ typedef __float128 _Float128; Converting a narrower sNaN to _Float128 produces a quiet NaN, so attempts to use _Float128 sNaNs will not work properly with older compilers. */ -# if !__GNUC_PREREQ (7, 0) +# if !__GNUC_PREREQ (7, 0) && !defined __clang__ # define __builtin_copysignf128 __builtin_copysignq # define __builtin_fabsf128 __builtin_fabsq # define __builtin_inff128() ((_Float128) __builtin_inf ()) @@ -133,7 +136,7 @@ typedef __float128 _Float128; e.g.: __builtin_signbitf128, before GCC 6. However, there has never been a __builtin_signbitf128 in GCC and the type-generic builtin is only available since GCC 6. */ -# if !__GNUC_PREREQ (6, 0) +# if !__GNUC_PREREQ (6, 0) && !defined __clang__ # define __builtin_signbitf128 __signbitf128 # endif