From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id D4EE93858C33; Wed, 15 Nov 2023 13:32:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D4EE93858C33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1700055130; bh=YaggfiktOFRNSZqO9OfTiAMH3H/nPJS+b3q4V3XQDrw=; h=From:To:Subject:Date:From; b=qmklNR9sgMgjpT3TYEUX0GPox+uBdT66gQ5PoAQqvZIhbGsNH5wZFTeC/l5OPo1oo 3cKyXyQSQLOnCKzhZ9HjgSOnDvACinUfCJFIKg+287FLK0V80nUp2t/Qyvn9CN9xNu T3fMf6Dsn9KNfWthOY5sT5tQ4DaAT7FDG/kzqIdc= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc] sparc: Fix broken memset for sparc32 [BZ #31068] X-Act-Checkin: glibc X-Git-Author: Andreas Larsson X-Git-Refname: refs/heads/master X-Git-Oldrev: baea60b33ec52e413cffad59d7dc54957377ac14 X-Git-Newrev: 578190b7e43305141512dee777e4a3b3e8159393 Message-Id: <20231115133210.D4EE93858C33@sourceware.org> Date: Wed, 15 Nov 2023 13:32:10 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=578190b7e43305141512dee777e4a3b3e8159393 commit 578190b7e43305141512dee777e4a3b3e8159393 Author: Andreas Larsson Date: Wed Nov 15 13:29:43 2023 +0100 sparc: Fix broken memset for sparc32 [BZ #31068] Fixes commit a61933fe27df ("sparc: Remove bzero optimization") that after moving code jumped to the wrong label 4. Verfied by successfully running string/test-memset on sparc32. Signed-off-by: Andreas Larsson Signed-off-by: Ludwig Rydberg Reviewed-by: Adhemerval Zanella Diff: --- sysdeps/sparc/sparc32/memset.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sysdeps/sparc/sparc32/memset.S b/sysdeps/sparc/sparc32/memset.S index ca29ff5685..1dc3a640e8 100644 --- a/sysdeps/sparc/sparc32/memset.S +++ b/sysdeps/sparc/sparc32/memset.S @@ -55,7 +55,7 @@ ENTRY(memset) andcc %o0, 3, %o2 bne 3f -4: andcc %o0, 4, %g0 +5: andcc %o0, 4, %g0 be 2f mov %g3, %g2 @@ -139,7 +139,7 @@ ENTRY(memset) stb %g3, [%o0 + 0x02] 2: sub %o2, 4, %o2 add %o1, %o2, %o1 - b 4b + b 5b sub %o0, %o2, %o0 END(memset) libc_hidden_builtin_def (memset)