From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2178) id 754C63858D20; Wed, 20 Dec 2023 15:14:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 754C63858D20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1703085285; bh=jLPxkirfe/baVf4DoWfRKsXjKNhWxzumBmtdpsajaoc=; h=From:To:Subject:Date:From; b=NrLI9rk2k8vRPm6jijJXkie6NHfu7HviFnkKrUr6d21K6X1eDPxdfM0DUMG2cXjSM 6w7OdVEOMamvHIZD3X84DLK7cGT1a3y1L1yj1wdIC4tJPr7vIolGWxwG26lxPkCmBx lH4AM0SPlKzz8fTxUBI6pRQBOKUS1DV4E3dLQ/As= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Florian Weimer To: glibc-cvs@sourceware.org Subject: [glibc] nss: Remove unused allocation from get_nscd_addresses in getaddrinfo X-Act-Checkin: glibc X-Git-Author: Florian Weimer X-Git-Refname: refs/heads/master X-Git-Oldrev: 41560a9312ce0ec7203480eef8f865076bff9edb X-Git-Newrev: 61bac1a9d2ab80ebcbc51484722e6ea43414bec7 Message-Id: <20231220151445.754C63858D20@sourceware.org> Date: Wed, 20 Dec 2023 15:14:45 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=61bac1a9d2ab80ebcbc51484722e6ea43414bec7 commit 61bac1a9d2ab80ebcbc51484722e6ea43414bec7 Author: Florian Weimer Date: Wed Dec 20 16:14:33 2023 +0100 nss: Remove unused allocation from get_nscd_addresses in getaddrinfo No bug because this is not visible if glibc is built with optimization. Otherwise this would be a critical resource leak. Reviewed-by: Carlos O'Donell Diff: --- nss/getaddrinfo.c | 1 - 1 file changed, 1 deletion(-) diff --git a/nss/getaddrinfo.c b/nss/getaddrinfo.c index 531124958d..ce3af931b2 100644 --- a/nss/getaddrinfo.c +++ b/nss/getaddrinfo.c @@ -514,7 +514,6 @@ get_nscd_addresses (const char *name, const struct addrinfo *req, int result = 0; char *addrs = air->addrs; - struct gaih_addrtuple *addrfree = calloc (air->naddrs, sizeof (*addrfree)); struct gaih_addrtuple *at = calloc (air->naddrs, sizeof (*at)); if (at == NULL) {