From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id 3691D3858030; Thu, 21 Dec 2023 18:50:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3691D3858030 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1703184658; bh=5BpzDz09FHYXgrxcJMl1s3atrAWWKMC5zhAaLVvGGPk=; h=From:To:Subject:Date:From; b=ezWmqFH/OxEQk2ftLRzbtn6iLFaSZJAUwKJrA1LzEhkXHmsleKeAvDKp2Qtus4hTJ xtyjIw+IFZxk1RExA22Dz7H3uBLRQcJUvntVDLzvRjxgu/ISBkOeP7nwIVonleFS5S L/P0wZWzhwTnG/68/ZT7AtBGcP3wR/P6n1g3H1Kk= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] Disable __USE_EXTERN_INLINES for clang X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/clang X-Git-Oldrev: 7451d5a8944fc0e153f9c8f2a547c2e0e8c32b61 X-Git-Newrev: e88ce25d5f32078b23132b2be53c02f67bf55378 Message-Id: <20231221185058.3691D3858030@sourceware.org> Date: Thu, 21 Dec 2023 18:50:58 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=e88ce25d5f32078b23132b2be53c02f67bf55378 commit e88ce25d5f32078b23132b2be53c02f67bf55378 Author: Adhemerval Zanella Date: Thu Oct 7 18:16:04 2021 -0700 Disable __USE_EXTERN_INLINES for clang clang does not allow to redefine attributes after function declaration. Although it work for external usage, its breaks the build for internal symbol that glibc provides as optimization (for instance bsearch with stdlib-bsearch.h or __cmsg_nxthdr). Disable such optimization for clang while building glibc. Diff: --- include/features.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/features.h b/include/features.h index 7c51b4a2e4..a94fc1b3a4 100644 --- a/include/features.h +++ b/include/features.h @@ -515,7 +515,7 @@ /* Decide whether we can define 'extern inline' functions in headers. */ #if __GNUC_PREREQ (2, 7) && defined __OPTIMIZE__ \ && !defined __OPTIMIZE_SIZE__ && !defined __NO_INLINE__ \ - && defined __extern_inline + && defined __extern_inline && !(defined __clang__ && defined _LIBC) # define __USE_EXTERN_INLINES 1 #endif