From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id B8EE93857C51; Thu, 21 Dec 2023 18:51:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B8EE93857C51 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1703184693; bh=OvEWOh+NEb4hbLgHDKn/i7L8A1O9HRAYiJ53plT6Dds=; h=From:To:Subject:Date:From; b=qncYfm4fBpQAv+3FxoFmS0jHXxMOqjaRJOeG4Q27T2SAht0u8GRZEruxRarr6zrMs YI4nM0gaOP+DMzQO5/ohXHxLwRgQWiVHg+r9eiQTlYA+ZL7wQAOKfkq3nBvE2rtQd8 f3XuRd0jIDnxCCAoLe+nXWOJr8iLQf9Qnt2c2/4c= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] resolv: Handle -Wsometimes-uninitialized on getaddrinfo X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/clang X-Git-Oldrev: 4b8c842ee20010ece92b302b35616f7e584ab7b3 X-Git-Newrev: 9274f60d0ec193ff94d1c2a44f5288206d143ee2 Message-Id: <20231221185133.B8EE93857C51@sourceware.org> Date: Thu, 21 Dec 2023 18:51:33 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9274f60d0ec193ff94d1c2a44f5288206d143ee2 commit 9274f60d0ec193ff94d1c2a44f5288206d143ee2 Author: Adhemerval Zanella Date: Tue Mar 22 16:01:34 2022 -0300 resolv: Handle -Wsometimes-uninitialized on getaddrinfo Diff: --- nss/getaddrinfo.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/nss/getaddrinfo.c b/nss/getaddrinfo.c index ce3af931b2..259b7b9a7c 100644 --- a/nss/getaddrinfo.c +++ b/nss/getaddrinfo.c @@ -1873,6 +1873,10 @@ add_prefixlist (struct prefixlist **listp, size_t *lenp, bool *nullbitsp, if (cp != NULL) *cp++ = '\0'; *pos = cp; + /* clang warns that endp is used uninitialized whenever '||' condition + is true, however it will be evaluated after strtoul call. */ + DIAG_PUSH_NEEDS_COMMENT_CLANG; + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wsometimes-uninitialized"); if (inet_pton (AF_INET6, val1, &prefix) && (cp == NULL || (bits = strtoul (cp, &endp, 10)) != ULONG_MAX @@ -1896,6 +1900,7 @@ add_prefixlist (struct prefixlist **listp, size_t *lenp, bool *nullbitsp, ++*lenp; *nullbitsp |= bits == 0; } + DIAG_POP_NEEDS_COMMENT_CLANG; return true; } @@ -2034,6 +2039,11 @@ gaiconf_init (void) if (inet_pton (AF_INET6, val1, &prefix)) { bits = 128; + /* clang warns that endp is used uninitialized whenever '||' + condition is true, however it will be evaluated after + strtoul call. */ + DIAG_PUSH_NEEDS_COMMENT_CLANG; + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wsometimes-uninitialized"); if (IN6_IS_ADDR_V4MAPPED (&prefix) && (cp == NULL || (bits = strtoul (cp, &endp, 10)) != ULONG_MAX @@ -2055,6 +2065,7 @@ gaiconf_init (void) goto no_file; } } + DIAG_POP_NEEDS_COMMENT_CLANG; } else if (inet_pton (AF_INET, val1, &prefix.s6_addr32[3]) && (cp == NULL