From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id 12B20385DC00; Thu, 21 Dec 2023 18:51:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 12B20385DC00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1703184714; bh=HUIVeAjkxRGDaOVYI6fjwUnf2rXdkmbhW6tsGTHNkPU=; h=From:To:Subject:Date:From; b=qrI7ZBZt4OP5LIyzOtfYzF7jLPOTMkJ++vv4o+7cDV4paARmapkN4lkGKnP+w5Y/d OXlDVLJMHmG9MklOTTgUNeO9ADvnujkhjLljuI0sqW76xVkX8jUcto59jEe9LEXVLr qbFheDd3j9iIns12/QcSUTIELSWtq4HljdS4sMFM= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] nss: Suppress nss_module.c warning on clang X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/clang X-Git-Oldrev: abeec8fdd47469679f6e96d649e45a9cc6d2ea0c X-Git-Newrev: 4edf9318955b276f0376cc66ccb06981ac6a82bb Message-Id: <20231221185154.12B20385DC00@sourceware.org> Date: Thu, 21 Dec 2023 18:51:54 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=4edf9318955b276f0376cc66ccb06981ac6a82bb commit 4edf9318955b276f0376cc66ccb06981ac6a82bb Author: Adhemerval Zanella Date: Thu Mar 10 08:31:06 2022 -0300 nss: Suppress nss_module.c warning on clang clang issues an warning adding 'unsigned long' to a string does not append to the string, however it is exactly what code means here. Diff: --- nss/nss_module.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/nss/nss_module.c b/nss/nss_module.c index 0104f88974..ee99598e70 100644 --- a/nss/nss_module.c +++ b/nss/nss_module.c @@ -33,6 +33,8 @@ #include #include #include +#include +#include /* Suffix after .so of NSS service modules. This is a bit of magic, but we assume LIBNSS_FILES_SO looks like "libnss_files.so.2" and we @@ -40,8 +42,14 @@ except through the auto-generated lib-names.h and some static pointer manipulation. The "-1" accounts for the trailing NUL included in the sizeof. */ + +/* clang issues an warning adding 'unsigned long' to a string does not append + to the string, however it is exactly what code means here. */ +DIAG_PUSH_NEEDS_COMMENT_CLANG; +DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wstring-plus-int"); static const char *const __nss_shlib_revision = LIBNSS_FILES_SO + sizeof("libnss_files.so") - 1; +DIAG_POP_NEEDS_COMMENT_CLANG; /* A single-linked list used to implement a mapping from service names to NSS modules. (Most systems only use five or so modules, so a