From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id 693663858415; Thu, 21 Dec 2023 18:52:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 693663858415 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1703184739; bh=WUSaCZt4jtHwuJvFbgzRhlx4kuIrBfm/TNczOm+t6Ok=; h=From:To:Subject:Date:From; b=YSQ4Tr+V7mkqUNfcZ+oN8hXzQuJB8HWUYsL1n31aX338HVjYRP2jcbci1boI9Orqq L0CSM+o3xLwYzi0wHSts9fpsdbT7GQ2ZPnbUfUPOXIOvBbQ5jMdp6BTRDu2EKHFRYS iKV0HSYkvAAnO1wWQh1s/JsFIlpcTxG3B4tCdNUM= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] elf: Suppress clang -Wstring-plus-int on rtld.c X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/clang X-Git-Oldrev: 69e3b041a17afc126d3592c52e13249b6e99acdd X-Git-Newrev: e0378feba45f8fcbd10bd1bdc909aafe7f670712 Message-Id: <20231221185219.693663858415@sourceware.org> Date: Thu, 21 Dec 2023 18:52:19 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=e0378feba45f8fcbd10bd1bdc909aafe7f670712 commit e0378feba45f8fcbd10bd1bdc909aafe7f670712 Author: Adhemerval Zanella Date: Thu Mar 10 09:48:32 2022 -0300 elf: Suppress clang -Wstring-plus-int on rtld.c clang issues an warning adding 'const unsigned char' to a string does not append to the string, however it is exactly what code means here. Diff: --- elf/rtld.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/elf/rtld.c b/elf/rtld.c index 326286f3b2..a8b7c27603 100644 --- a/elf/rtld.c +++ b/elf/rtld.c @@ -2520,10 +2520,16 @@ warning: debug option `%s' unknown; try LD_DEBUG=help\n", copy); _dl_printf ("\ Valid options for the LD_DEBUG environment variable are:\n\n"); + /* clang issues an warning adding 'const unsigned char' to a string + does not append to the string, however it is exactly what code + means here. */ + DIAG_PUSH_NEEDS_COMMENT_CLANG; + DIAG_IGNORE_NEEDS_COMMENT_CLANG (16, "-Wstring-plus-int"); for (cnt = 0; cnt < ndebopts; ++cnt) _dl_printf (" %.*s%s%s\n", debopts[cnt].len, debopts[cnt].name, " " + debopts[cnt].len - 3, debopts[cnt].helptext); + DIAG_POP_NEEDS_COMMENT_CLANG; _dl_printf ("\n\ To direct the debugging output into a file instead of standard output\n\