From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id 1EC2B385842B; Thu, 21 Dec 2023 18:53:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1EC2B385842B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1703184785; bh=ALE+zv7CemfAjaV2Jzans8xP/UUxaV/62x294BuL6L4=; h=From:To:Subject:Date:From; b=L4+F9ubPxj2gJNTnvbKAQt2m1D+Vga9XK0/+selBI+57BzJdoOu9D6gBkTDbZr0g/ pHH5dKLOXshlAKoczvzAWx9t56RyQSreapnI6JLhTb6LgVXo7PlLHCn8D8Vty+0Scg H4og94hHa/hm0JgQt58fDYjcf4lCqep6YGVv18PY= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] timezone: Fix clang operator precedence warning X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/clang X-Git-Oldrev: 9de7d6f585393b6d1e455bbb5c4195797774330e X-Git-Newrev: f6ce9fe8be8ccea410946365aa50f59dabc2c4e2 Message-Id: <20231221185305.1EC2B385842B@sourceware.org> Date: Thu, 21 Dec 2023 18:53:05 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f6ce9fe8be8ccea410946365aa50f59dabc2c4e2 commit f6ce9fe8be8ccea410946365aa50f59dabc2c4e2 Author: Adhemerval Zanella Date: Thu Mar 10 16:44:45 2022 -0300 timezone: Fix clang operator precedence warning clang issues: zdump.c:669:7: error: operator '?:' has lower precedence than '&'; '&' will be evaluated first [-Werror,-Wbitwise-conditional-parentheses] ? (delta(&tm, &lotm) == t - lot which is exactly what the code intendes. Instead of adding a warning suppress, place parentheses around the '&' expression. Diff: --- timezone/zdump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/timezone/zdump.c b/timezone/zdump.c index b532fe3eae..bfc01faffa 100644 --- a/timezone/zdump.c +++ b/timezone/zdump.c @@ -665,7 +665,7 @@ hunt(timezone_t tz, char *name, time_t lot, time_t hit) else if (t >= hit) --t; tm_ok = my_localtime_rz(tz, &t, &tm) != NULL; - if (lotm_ok & tm_ok + if ((lotm_ok & tm_ok) ? (delta(&tm, &lotm) == t - lot && tm.tm_isdst == lotm.tm_isdst && strcmp(abbr(&tm), ab) == 0)