From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id 909C93858427; Thu, 21 Dec 2023 18:53:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 909C93858427 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1703184815; bh=IH8P1AweALhvT8THutFKe2Y2zJ/n3xl9xv/jzeFUNYY=; h=From:To:Subject:Date:From; b=O0q6pctgQqIye6aCz9uiaTsvRtm39OK1RwTUVex9HwQU8Narh30TEp+CS2KWB9AfN XAbUKtXQsZACkO6RIyaHQpCUfz4x27Yq00su3ABFr8Wg8/oQ6uURE8jFuXe4lez/er 3zBTEWtBeI5JQmk7H4qs6unuc5nUXBt4t3QCbEf4= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] stdlib: Only enable strtod_l asserts if SIZE_MAX == UINTMAX_MAX X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/clang X-Git-Oldrev: e7422ecd294da6d25c0f534b9cfb1d745a37e8ab X-Git-Newrev: 79910ce8c4117faefee27cfff9ec1cb9e33e10cc Message-Id: <20231221185335.909C93858427@sourceware.org> Date: Thu, 21 Dec 2023 18:53:35 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=79910ce8c4117faefee27cfff9ec1cb9e33e10cc commit 79910ce8c4117faefee27cfff9ec1cb9e33e10cc Author: Adhemerval Zanella Date: Tue Jul 26 08:38:48 2022 -0300 stdlib: Only enable strtod_l asserts if SIZE_MAX == UINTMAX_MAX clang on 32 bits where size_t is smaller than intmax_t emits: strtod_l.c:874:18: error: result of comparison of constant 9223372036854775807 with expression of type 'size_t' (aka 'unsigned int') is always true [-Werror,-Wtautological-constant-out-of-range-compare] assert (dig_no <= (uintmax_t) INTMAX_MAX); ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ ../assert/assert.h:106:11: note: expanded from macro 'assert' if (expr) \ ^~~~ So only enable the assert iff SIZE_MAX == UINTMAX_MAX. Diff: --- stdlib/strtod_l.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/stdlib/strtod_l.c b/stdlib/strtod_l.c index c5cbb39dff..7d79ff2241 100644 --- a/stdlib/strtod_l.c +++ b/stdlib/strtod_l.c @@ -871,7 +871,10 @@ ____STRTOF_INTERNAL (const STRING_TYPE *nptr, STRING_TYPE **endptr, int group, c = *++cp; } } + +#if SIZE_MAX == UINTMAX_MAX assert (dig_no <= (uintmax_t) INTMAX_MAX); +#endif /* Remember start of exponent (if any). */ expp = cp; @@ -901,16 +904,20 @@ ____STRTOF_INTERNAL (const STRING_TYPE *nptr, STRING_TYPE **endptr, int group, { if (exp_negative) { +#if SIZE_MAX == UINTMAX_MAX assert (int_no <= (uintmax_t) (INTMAX_MAX + MIN_EXP - MANT_DIG) / 4); +#endif exp_limit = -MIN_EXP + MANT_DIG + 4 * (intmax_t) int_no; } else { if (int_no) { +#if SIZE_MAX == UINTMAX_MAX assert (lead_zero == 0 && int_no <= (uintmax_t) INTMAX_MAX / 4); +#endif exp_limit = MAX_EXP - 4 * (intmax_t) int_no + 3; } else if (lead_zero == (size_t) -1) @@ -921,8 +928,10 @@ ____STRTOF_INTERNAL (const STRING_TYPE *nptr, STRING_TYPE **endptr, int group, } else { +#if SIZE_MAX == UINTMAX_MAX assert (lead_zero <= (uintmax_t) (INTMAX_MAX - MAX_EXP - 3) / 4); +#endif exp_limit = (MAX_EXP + 4 * (intmax_t) lead_zero + 3); @@ -933,16 +942,20 @@ ____STRTOF_INTERNAL (const STRING_TYPE *nptr, STRING_TYPE **endptr, int group, { if (exp_negative) { +#if SIZE_MAX == UINTMAX_MAX assert (int_no <= (uintmax_t) (INTMAX_MAX + MIN_10_EXP - MANT_DIG)); +#endif exp_limit = -MIN_10_EXP + MANT_DIG + (intmax_t) int_no; } else { if (int_no) { +#if SIZE_MAX == UINTMAX_MAX assert (lead_zero == 0 && int_no <= (uintmax_t) INTMAX_MAX); +#endif exp_limit = MAX_10_EXP - (intmax_t) int_no + 1; } else if (lead_zero == (size_t) -1) @@ -953,8 +966,10 @@ ____STRTOF_INTERNAL (const STRING_TYPE *nptr, STRING_TYPE **endptr, int group, } else { +#if SIZE_MAX == UINTMAX_MAX assert (lead_zero <= (uintmax_t) (INTMAX_MAX - MAX_10_EXP - 1)); +#endif exp_limit = MAX_10_EXP + (intmax_t) lead_zero + 1; } }