From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id 81DF33858292; Thu, 21 Dec 2023 18:55:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 81DF33858292 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1703184942; bh=Wy3WzRldSoHLh/OGlwZ/BdxZhuQQdBYAW3i2bm6FEtE=; h=From:To:Subject:Date:From; b=pNbPDKGdsbdm/NA2al1bLWua/01jShx4MoTpabSfyn/Vy/Wna76stWCQO6Iplsw9I lfl4rr5knBbV4nq0WNs46wKgXhpYnOkPDnNsgj4bJosSApPQyLGBuCPzWBBp8Uq2+h g2CKeaMdI7ztypaRlFm6G1SecoqM1RMXDX57Jyb4= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] math: Only build tests for _Complex __int128 iff compiler supports it X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/clang X-Git-Oldrev: c58898d6acd1f565af0e2953c7d1cd5c590823cc X-Git-Newrev: 8eeaf9038e5cc4337615cedcbd09c0ed4b1713bd Message-Id: <20231221185542.81DF33858292@sourceware.org> Date: Thu, 21 Dec 2023 18:55:42 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8eeaf9038e5cc4337615cedcbd09c0ed4b1713bd commit 8eeaf9038e5cc4337615cedcbd09c0ed4b1713bd Author: Adhemerval Zanella Date: Thu Mar 24 14:24:08 2022 -0300 math: Only build tests for _Complex __int128 iff compiler supports it clang fails building test-tgmath3-atan2.c: error: '_Complex __int128' is invalid _Complex __int128 var__Complex___int128 __attribute__ ((unused)); since it does not support _Complex with __int128. So disable the test in such case. Diff: --- configure | 29 +++++++++++++++++++++++++++++ configure.ac | 17 +++++++++++++++++ math/Makefile | 2 +- math/gen-tgmath-tests.py | 38 +++++++++++++++++++++++++++++--------- 4 files changed, 76 insertions(+), 10 deletions(-) diff --git a/configure b/configure index a811663fe4..3075261273 100755 --- a/configure +++ b/configure @@ -7388,6 +7388,35 @@ printf "%s\n" "$libc_cv_cc_float_store" >&6; } config_vars="$config_vars config-cflags-float-store = $libc_cv_cc_float_store" +{ printf "%s\n" "$as_me:${as_lineno-$LINENO}: checking whether compiler supports _Complex with __int128" >&5 +printf %s "checking whether compiler supports _Complex with __int128... " >&6; } +if test ${libc_cv_complex_int128+y} +then : + printf %s "(cached) " >&6 +else $as_nop + cat > conftest.c <&5 + (eval $ac_try) 2>&5 + ac_status=$? + printf "%s\n" "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5 + test $ac_status = 0; }; } +then + libc_cv_complex_int128=yes +fi +rm -f conftest* +fi +{ printf "%s\n" "$as_me:${as_lineno-$LINENO}: result: $libc_cv_complex_int128" >&5 +printf "%s\n" "$libc_cv_complex_int128" >&6; } +config_vars="$config_vars +config-complex-int128 = $libc_cv_complex_int128" + { printf "%s\n" "$as_me:${as_lineno-$LINENO}: checking if $CC accepts -fno-tree-loop-distribute-patterns with \ __attribute__ ((__optimize__))" >&5 printf %s "checking if $CC accepts -fno-tree-loop-distribute-patterns with \ diff --git a/configure.ac b/configure.ac index 1f9d8b6e5e..a6e05cf585 100644 --- a/configure.ac +++ b/configure.ac @@ -1488,6 +1488,23 @@ LIBC_TRY_CC_OPTION([-Werror -ffloat-store], LIBC_CONFIG_VAR([config-cflags-float-store], [$libc_cv_cc_float_store]) +AC_CACHE_CHECK([whether compiler supports _Complex with __int128], + [libc_cv_complex_int128], [dnl +cat > conftest.c <&AS_MESSAGE_LOG_FD]) +then + libc_cv_complex_int128=yes +fi +rm -f conftest*]) +LIBC_CONFIG_VAR([config-complex-int128], + [$libc_cv_complex_int128]) + AC_CACHE_CHECK(if $CC accepts -fno-tree-loop-distribute-patterns with \ __attribute__ ((__optimize__)), libc_cv_cc_loop_to_function, [dnl cat > conftest.c < $@ + $(PYTHON) gen-tgmath-tests.py --complex-int128 $(config-complex-int128) $* > $@ # Verify that the list of supported macros is in sync between the # Makefile and gen-tgmath-tests.py. diff --git a/math/gen-tgmath-tests.py b/math/gen-tgmath-tests.py index 0882c7341a..e16ba0b0b0 100755 --- a/math/gen-tgmath-tests.py +++ b/math/gen-tgmath-tests.py @@ -53,6 +53,7 @@ # supported on any given configuration of glibc, the MANT_DIG value # uniquely determines the format. +import argparse import string import sys @@ -182,7 +183,7 @@ class Type(object): return self.name @staticmethod - def init_types(): + def init_types(complex_int128): """Initialize all the known types.""" Type.create_type('_Float16', 'f16', 'FLT16_MANT_DIG', complex_name='__CFLOAT16', @@ -219,9 +220,11 @@ class Type(object): Type.create_type('long long int', integer=True) Type.create_type('unsigned long long int', integer=True) Type.create_type('__int128', integer=True, - condition='defined __SIZEOF_INT128__') + condition='defined __SIZEOF_INT128__', + complex_ok=complex_int128) Type.create_type('unsigned __int128', integer=True, - condition='defined __SIZEOF_INT128__') + condition='defined __SIZEOF_INT128__', + complex_ok=complex_int128) Type.create_type('enum e', integer=True, complex_ok=False) Type.create_type('_Bool', integer=True, complex_ok=False) Type.create_type('bit_field', integer=True, complex_ok=False) @@ -834,15 +837,32 @@ class Tests(object): print('error: macro list mismatch') sys.exit(1) -def main(): +def get_parser(): + def strbool(string): + return True if string.lower() == 'yes' else False + + parser = argparse.ArgumentParser(description=__doc__) + parser.add_argument('--complex-int128', dest='complex_int128', + help='Generate tests for _Complex __int128', + type=strbool) + parser.add_argument('--check-list', action='store_true', + help='Verify that the list of supported macros') + parser.add_argument('macro', + help='macro to test', + nargs='*') + return parser + +def main(argv): """The main entry point.""" - Type.init_types() + parser = get_parser() + opts = parser.parse_args(argv) + Type.init_types(True if opts.complex_int128 == 'yes' else False) t = Tests() - if sys.argv[1] == 'check-list': + if opts.check_list: macro = None - macro_list = sys.argv[2:] + macro_list = opts.macro else: - macro = sys.argv[1] + macro = opts.macro macro_list = [] t.add_all_tests(macro) if macro: @@ -851,4 +871,4 @@ def main(): t.check_macro_list(macro_list) if __name__ == '__main__': - main() + main(sys.argv[1:])