public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/azanella/clang] linux: Avoid indirection on operand of type 'void *' for gettimeofday
Date: Thu, 21 Dec 2023 19:00:01 +0000 (GMT) [thread overview]
Message-ID: <20231221190001.6233038618AE@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=7c8dd2778cd66a63cc31a32c0c471182d6db3b03
commit 7c8dd2778cd66a63cc31a32c0c471182d6db3b03
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date: Mon Sep 26 10:00:51 2022 -0300
linux: Avoid indirection on operand of type 'void *' for gettimeofday
ISO C does not allow and it fixes a clang issue with
-Werror,-Wvoid-ptr-dereference.
Checked on x86_64-linux-gnu.
Diff:
---
sysdeps/unix/sysv/linux/gettimeofday.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sysdeps/unix/sysv/linux/gettimeofday.c b/sysdeps/unix/sysv/linux/gettimeofday.c
index d3afd1a587..0f92b50f82 100644
--- a/sysdeps/unix/sysv/linux/gettimeofday.c
+++ b/sysdeps/unix/sysv/linux/gettimeofday.c
@@ -32,7 +32,7 @@ static int
__gettimeofday_syscall (struct timeval *restrict tv, void *restrict tz)
{
if (__glibc_unlikely (tz != 0))
- memset (tz, 0, sizeof *tz);
+ memset (tz, 0, sizeof (struct timezone));
return INLINE_SYSCALL_CALL (gettimeofday, tv, tz);
}
@@ -48,7 +48,7 @@ int
__gettimeofday (struct timeval *restrict tv, void *restrict tz)
{
if (__glibc_unlikely (tz != 0))
- memset (tz, 0, sizeof *tz);
+ memset (tz, 0, sizeof (struct timezone));
return INLINE_VSYSCALL (gettimeofday, 2, tv, tz);
}
next reply other threads:[~2023-12-21 19:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 19:00 Adhemerval Zanella [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-03-25 20:25 Adhemerval Zanella
2024-04-17 20:13 Adhemerval Zanella
2024-04-02 15:59 Adhemerval Zanella
2024-02-09 17:38 Adhemerval Zanella
2024-02-07 14:13 Adhemerval Zanella
2024-01-29 18:03 Adhemerval Zanella
2023-09-28 17:58 Adhemerval Zanella
2023-08-30 12:42 Adhemerval Zanella
2023-02-09 19:54 Adhemerval Zanella
2022-10-28 17:47 Adhemerval Zanella
2022-10-04 13:05 Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231221190001.6233038618AE@sourceware.org \
--to=azanella@sourceware.org \
--cc=glibc-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).