From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id 0B7F73858D39; Fri, 29 Dec 2023 19:59:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0B7F73858D39 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1703879982; bh=RMzHs5aKlRHia2Y0eTTGciRw3a8TbDelkpm/Vl7ZqY0=; h=From:To:Subject:Date:From; b=QTjD1tGZ0hOKiAHb4ktjmw3v8T8cthW7wuCBlEUNtuNIYja0cf4DLgGeNHKjwy+wM Hpzko0D5i0PDfeU74CY91p5RxbXfpaSzpn1VUQABIQqrKAit+E1a0jHai7kjXvHbLe /mOkaS4K3e9QPhjw2XzcGi3Ws1VERP8JFSqkAt2Q= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/bz23960-dirent] linux: Use getdents64 on non-LFS readdir X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/bz23960-dirent X-Git-Oldrev: fce5528fcb58aa3f44bdc6cbecdd5f6b75145b0c X-Git-Newrev: 396cc2c088afbf3846c54f6195fa98fa06d23e21 Message-Id: <20231229195942.0B7F73858D39@sourceware.org> Date: Fri, 29 Dec 2023 19:59:42 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=396cc2c088afbf3846c54f6195fa98fa06d23e21 commit 396cc2c088afbf3846c54f6195fa98fa06d23e21 Author: Adhemerval Zanella Date: Tue Oct 20 13:37:15 2020 -0300 linux: Use getdents64 on non-LFS readdir It is similar to what non-LFS getdents do (including overflow check). Checked on x86_64-linux-gnu and i686-linux-gnu. Diff: --- sysdeps/unix/sysv/linux/readdir.c | 97 +++++++++++++++++++++++++++++---------- 1 file changed, 73 insertions(+), 24 deletions(-) diff --git a/sysdeps/unix/sysv/linux/readdir.c b/sysdeps/unix/sysv/linux/readdir.c index 4a4c00ea07..72ba895afe 100644 --- a/sysdeps/unix/sysv/linux/readdir.c +++ b/sysdeps/unix/sysv/linux/readdir.c @@ -20,43 +20,92 @@ #if !_DIRENT_MATCHES_DIRENT64 #include +#include + +# ifndef DIRENT_SET_DP_INO +# define DIRENT_SET_DP_INO(dp, value) (dp)->d_ino = (value) +# endif /* Read a directory entry from DIRP. */ struct dirent * __readdir_unlocked (DIR *dirp) { - struct dirent *dp; int saved_errno = errno; - if (dirp->offset >= dirp->size) + while (1) { - /* We've emptied out our buffer. Refill it. */ - - size_t maxread = dirp->allocation; - ssize_t bytes; - - bytes = __getdents (dirp->fd, dirp->data, maxread); - if (bytes <= 0) + if (dirp->offset >= dirp->size) { - /* Linux may fail with ENOENT on some file systems if the - directory inode is marked as dead (deleted). POSIX - treats this as a regular end-of-directory condition, so - do not set errno in that case, to indicate success. */ - if (bytes == 0 || errno == ENOENT) - __set_errno (saved_errno); + ssize_t bytes = __getdents64 (dirp->fd, dirp->data, + dirp->allocation); + if (bytes <= 0) + { + /* Linux may fail with ENOENT on some file systems if the + directory inode is marked as dead (deleted). POSIX + treats this as a regular end-of-directory condition, so + do not set errno in that case, to indicate success. */ + if (bytes < 0 && errno == ENOENT) + __set_errno (saved_errno); + return NULL; + } + dirp->size = bytes; + + /* Reset the offset into the buffer. */ + dirp->offset = 0; + } + + /* These two pointers might alias the same memory buffer. Standard C + requires that we always use the same type for them, so we must use the + union type. */ + union + { + struct dirent64 dp64; + struct dirent dp; + char *b; + } *inp, *outp; + inp = (void*) &dirp->data[dirp->offset]; + outp = (void*) &dirp->data[dirp->offset]; + + const size_t size_diff = offsetof (struct dirent64, d_name) + - offsetof (struct dirent, d_name); + + /* Since inp->dp64.d_reclen is already aligned for the kernel structure + this may compute a value that is bigger than necessary. */ + size_t old_reclen = inp->dp64.d_reclen; + size_t new_reclen = ALIGN_UP (old_reclen - size_diff, + _Alignof (struct dirent)); + + if (!in_ino_t_range (inp->dp64.d_ino) + || !in_off_t_range (inp->dp64.d_off)) + { + /* Overflow. If there was at least one entry before this one, + return them without error, otherwise signal overflow. */ + if (dirp->offset != 0) + { + __lseek64 (dirp->fd, dirp->offset, SEEK_SET); + outp = (void*)(outp->b - dirp->data); + return &outp->dp; + } + __set_errno (EOVERFLOW); return NULL; } - dirp->size = (size_t) bytes; - /* Reset the offset into the buffer. */ - dirp->offset = 0; + /* Copy the data from INP and access only OUTP. */ + const uint64_t d_ino = inp->dp64.d_ino; + const int64_t d_off = inp->dp64.d_off; + const uint8_t d_type = inp->dp64.d_type; + outp->dp.d_ino = d_ino; + outp->dp.d_off = d_off; + outp->dp.d_reclen = new_reclen; + outp->dp.d_type = d_type; + memmove (outp->dp.d_name, inp->dp64.d_name, + old_reclen - offsetof (struct dirent64, d_name)); + + dirp->filepos = d_off; + dirp->offset += old_reclen; + + return &outp->dp; } - - dp = (struct dirent *) &dirp->data[dirp->offset]; - dirp->offset += dp->d_reclen; - dirp->filepos = dp->d_off; - - return dp; } struct dirent *