public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Samuel Thibault <sthibaul@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] mach: Drop SNARF_ARGS macro
Date: Wed,  3 Jan 2024 21:00:18 +0000 (GMT)	[thread overview]
Message-ID: <20240103210018.421E23858414@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=0d4a2f3576ebd92ca0001645a533bf70289f264e

commit 0d4a2f3576ebd92ca0001645a533bf70289f264e
Author: Sergey Bugaev <bugaevc@gmail.com>
Date:   Wed Jan 3 20:14:39 2024 +0300

    mach: Drop SNARF_ARGS macro
    
    We're obtaining arguments from the stack differently, see init-first.c.
    
    Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>

Diff:
---
 sysdeps/mach/sysdep.h     |  7 -------
 sysdeps/mach/x86/sysdep.h | 14 --------------
 2 files changed, 21 deletions(-)

diff --git a/sysdeps/mach/sysdep.h b/sysdeps/mach/sysdep.h
index 8eeac45bad..3e0553d80f 100644
--- a/sysdeps/mach/sysdep.h
+++ b/sysdeps/mach/sysdep.h
@@ -56,13 +56,6 @@
 /* This is not used on all machines.  */
 #endif
 
-/* Set variables ARGC, ARGV, and ENVP for the arguments
-   left on the stack by the microkernel.  */
-#ifndef SNARF_ARGS
-#define SNARF_ARGS(argc, argv, envp)
-#error SNARF_ARGS not defined by sysdeps/mach/MACHINE/sysdep.h
-#endif
-
 /* LOSE can be defined as the `halt' instruction or something
    similar which will cause the process to die in a characteristic
    way suggesting a bug.  */
diff --git a/sysdeps/mach/x86/sysdep.h b/sysdeps/mach/x86/sysdep.h
index ed9f7f462a..63be5638e8 100644
--- a/sysdeps/mach/x86/sysdep.h
+++ b/sysdeps/mach/x86/sysdep.h
@@ -25,20 +25,6 @@
 
 #define LOSE asm volatile ("hlt")
 
-#define SNARF_ARGS(entry_sp, argc, argv, envp)				      \
-  do									      \
-    {									      \
-      char **p;								      \
-      argc = (int) *entry_sp;						      \
-      argv = (char **) (entry_sp + 1);					      \
-      p = argv;								      \
-      while (*p++ != NULL)						      \
-	;								      \
-      if (p >= (char **) argv[0])					      \
-	--p;								      \
-      envp = p;							      \
-    } while (0)
-
 #define STACK_GROWTH_DOWN
 
 /* Get the machine-independent Mach definitions.  */

                 reply	other threads:[~2024-01-03 21:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240103210018.421E23858414@sourceware.org \
    --to=sthibaul@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).