public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Pranav Kant <pranavk@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/google/grte/v5-2.27/master] Get rid of WANT_FLOAT128 usage in floatn.h
Date: Wed,  3 Jan 2024 21:51:24 +0000 (GMT)	[thread overview]
Message-ID: <20240103215124.3ED7B3857B99@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5ac69deee6f89df25fffc3db356e4acedc8ec09f

commit 5ac69deee6f89df25fffc3db356e4acedc8ec09f
Author: Pranav Kant <prka@google.com>
Date:   Thu Dec 28 22:46:30 2023 +0000

    Get rid of WANT_FLOAT128 usage in floatn.h
    
    This header is installed system-wide. It's not correct to introduce a new
    macro WANT_FLOAT128 in this because then we are either forcing the compiler to
    make it an inbuilt macro to make glibc expose all float128 functionality, or asking
    our clients to -DWANT_FLOAT128 to get float128 functionality in glibc.
    
    Given we are primarily going to have float128 enabled GRTE now, we don't need to have
    guards for non-float128 cases.

Diff:
---
 Makefile                  | 4 ----
 math/Makefile             | 4 ----
 sysdeps/x86/bits/floatn.h | 2 +-
 3 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/Makefile b/Makefile
index 084fec3331..bea4e27f8d 100644
--- a/Makefile
+++ b/Makefile
@@ -252,10 +252,6 @@ mostlyclean: parent-mostlyclean
 tests-clean:
 	@$(MAKE) subdir_testclean no_deps=t
 
-ifeq ($(enable-float128),yes)
-CPPFLAGS += -DWANT_FLOAT128=1
-endif
-
 ifneq (,$(CXX))
 vpath c++-types.data $(+sysdep_dirs)
 
diff --git a/math/Makefile b/math/Makefile
index 6ad3ccea20..ec7d91ca3d 100644
--- a/math/Makefile
+++ b/math/Makefile
@@ -160,10 +160,6 @@ gen-calls = s_ldexpF
 generated += $(foreach s,.c .S,$(call type-foreach, $(calls:s_%=m_%$(s))))
 routines = $(call type-foreach, $(calls))
 
-ifeq ($(enable-float128),yes)
-math-CPPFLAGS += -DWANT_FLOAT128=1
-endif
-
 ifeq ($(build-mathvec),yes)
 # We need to install libm.so and libm.a as linker scripts
 # for transparent use of vector math library.
diff --git a/sysdeps/x86/bits/floatn.h b/sysdeps/x86/bits/floatn.h
index 9dd9d8a40d..7387bbae38 100644
--- a/sysdeps/x86/bits/floatn.h
+++ b/sysdeps/x86/bits/floatn.h
@@ -33,7 +33,7 @@
 #if (defined __x86_64__							\
      ? __GNUC_PREREQ (4, 3)						\
      : (defined __GNU__ ? __GNUC_PREREQ (4, 5) : __GNUC_PREREQ (4, 4))) \
-    || (defined __clang__ && defined WANT_FLOAT128 && WANT_FLOAT128 == 1)
+    || defined __clang__
 # define __HAVE_FLOAT128 1
 #else
 # define __HAVE_FLOAT128 0

                 reply	other threads:[~2024-01-03 21:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240103215124.3ED7B3857B99@sourceware.org \
    --to=pranavk@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).