From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1792) id 0FDAC387085F; Thu, 4 Jan 2024 22:49:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0FDAC387085F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1704408578; bh=GHjBkrYs6h+zL5rb4e2kJ7OQ2m2Ojm/Z/g/wY5ewNhQ=; h=From:To:Subject:Date:From; b=PaMHqj4Lwm2+OyW+QHZbKWyfTxatoL5rCBlj2k3ZIp1tufZDKMQNkc2eCUmgnzssA TQpkq93P/fa/0Gq3niYiHmtIAkV1SnzEcCriU1LyAxsBH791aoV4j4drry2RF9PRuP ncfxtadJXuFq62up1kykmAcpNDumasfoKfDjZQVA= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Samuel Thibault To: glibc-cvs@sourceware.org Subject: [glibc] hurd: Drop x86-specific assembly from init-first.c X-Act-Checkin: glibc X-Git-Author: Sergey Bugaev X-Git-Refname: refs/heads/master X-Git-Oldrev: 24b707c1665afae7eb302542ffa92d53aa577111 X-Git-Newrev: b44ad8944b84dd83e89b50e298ee15701c8f2706 Message-Id: <20240104224938.0FDAC387085F@sourceware.org> Date: Thu, 4 Jan 2024 22:49:38 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b44ad8944b84dd83e89b50e298ee15701c8f2706 commit b44ad8944b84dd83e89b50e298ee15701c8f2706 Author: Sergey Bugaev Date: Wed Jan 3 20:14:41 2024 +0300 hurd: Drop x86-specific assembly from init-first.c We already have the RETURN_TO macro for this exact use case, and it's already used in the non-static code path. Use it here too. Signed-off-by: Sergey Bugaev Message-ID: <20240103171502.1358371-9-bugaevc@gmail.com> Diff: --- sysdeps/mach/hurd/x86/init-first.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/sysdeps/mach/hurd/x86/init-first.c b/sysdeps/mach/hurd/x86/init-first.c index 6f71d71bf0..211b2096b6 100644 --- a/sysdeps/mach/hurd/x86/init-first.c +++ b/sysdeps/mach/hurd/x86/init-first.c @@ -218,15 +218,7 @@ _hurd_stack_setup (void **argptr) void doinit (intptr_t *data) { init ((void **) data); -# ifdef __x86_64__ - asm volatile ("movq %0, %%rsp\n" /* Switch to new outermost stack. */ - "xorq %%rbp, %%rbp\n" /* Clear outermost frame pointer. */ - "jmp *%1" : : "r" (data), "r" (caller)); -# else - asm volatile ("movl %0, %%esp\n" /* Switch to new outermost stack. */ - "xorl %%ebp, %%ebp\n" /* Clear outermost frame pointer. */ - "jmp *%1" : : "r" (data), "r" (caller)); -# endif + RETURN_TO (data, caller, 0); __builtin_unreachable (); }